[GitHub] [iceberg] rdblue commented on pull request #796: Support Spark Structured Streaming Read for Iceberg

[GitBox <gi...@apache.org>]

rdblue commented on pull request #796:
URL: https://github.com/apache/iceberg/pull/796#issuecomment-722071336


   Thanks for the recent update, @jerryshao! Now that 0.10.0 is about ready to go, I think I will have more time to help get this in.
   
   I've found it difficult to review this one, I think because I've ended up losing context between reviews. Right now, the changes are large enough that it takes me a few days to get time to review. And if it takes you a few days to get the time to update, then we end up with quite a while between reviews and it is harder to pick it back up and continue. I think to avoid that, we may want to look for ways to break this into smaller, easier to review changes. Is there anything that you think we can split out right now? The changes to `SnapshotUtil` look likely.
   
   Also, I opened #1723 to make the offset a bit simpler, hopefully that helps.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org