You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "bvolpato (via GitHub)" <gi...@apache.org> on 2026/08/29 22:46:45 UTC

[PR] Fix flaky Playground local cache test [beam]

bvolpato opened a new pull request, #39918:
URL: https://github.com/apache/beam/pull/39918

   ## Summary
   
   `TestLocalCache_SetValue` configured its cache entry to expire one millisecond after fixture creation. The test then calls `SetValue` and `GetValue`, so a slow runner can cross that deadline and fail even though `SetValue` worked.
   
   This change leaves the expiration map empty for this test. Both `SetValue` cases still verify that the stored value can be read, including the `RunOutputIndex` conversion path. Expiration behavior remains covered separately by `TestLocalCache_GetValue`.
   
   ## Reproduction
   
   The scheduled Playground precommit failed in `TestLocalCache_SetValue/Set_value` because `GetValue` reported the newly stored value as missing:
   
   https://github.com/apache/beam/actions/runs/33273173203
   
   The failure depends on runner timing because the original deadline was only one millisecond.
   
   ## Testing
   
   - `cd playground/backend && go test ./internal/cache/local`
   - `cd playground/backend && go test ./internal/cache/local -run '^TestLocalCache_SetValue$' -count=10000`
   - `cd playground/backend && go test -race ./internal/cache/local -run '^TestLocalCache_SetValue$' -count=100`
   
   `./gradlew :playground:backend:test` also ran the changed cache package successfully, then stopped on unrelated local emulator and Scio setup failures.
   
   ------------------------
   
   - [x] No tracking issue; failing CI run is linked above.
   - [x] `CHANGES.md` is unchanged because this is a test-only stabilization.
   - [x] This contribution is not large.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flaky Playground local cache tests [beam]

Posted by "damccorm (via GitHub)" <gi...@apache.org>.
damccorm merged PR #39918:
URL: https://github.com/apache/beam/pull/39918


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix flaky Playground local cache test [beam]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39918:
URL: https://github.com/apache/beam/pull/39918#issuecomment-5465431200

   Assigning reviewers:
   
   R: @damccorm added as fallback since no labels match configuration
   
   
   Note: If you would like to opt out of this review, comment `assign to next reviewer`.
   
   Available commands:
   - `stop reviewer notifications` - opt out of the automated review tooling
   - `remind me after tests pass` - tag the comment author after tests pass
   - `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
   
   The PR bot will only process comments in the main thread (not review comments).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org