You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by "duowan1520 (via GitHub)" <gi...@apache.org> on 2023/05/09 02:28:23 UTC

[GitHub] [inlong] duowan1520 commented on a diff in pull request #7924: [INLONG-7900][Sort] Support partition by primary key when upsert single table of Kafka

duowan1520 commented on code in PR #7924:
URL: https://github.com/apache/inlong/pull/7924#discussion_r1188053827


##########
inlong-sort/sort-connectors/kafka/src/main/java/org/apache/inlong/sort/kafka/partitioner/PrimaryKeyPartitioner.java:
##########


Review Comment:
   Should we consider elevating the logic for extracting primary keys to a higher level and then merging the PrimaryKeyPartitioner and RawDataHashPartitioner into a hash-based Partitioner? This would help avoid introducing different partitioners when choosing between synchronizing a single table or multiple tables.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org