You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/10/16 12:10:45 UTC
[GitHub] [incubator-nuttx] xiaoxiang781216 opened a new pull request, #7327: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode
xiaoxiang781216 opened a new pull request, #7327:
URL: https://github.com/apache/incubator-nuttx/pull/7327
## Summary
## Impact
Minor
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #7327: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #7327:
URL: https://github.com/apache/incubator-nuttx/pull/7327#discussion_r996435401
##########
include/spawn.h:
##########
@@ -216,6 +217,12 @@ int task_spawnattr_getstacksize(FAR const posix_spawnattr_t *attr,
FAR size_t *stacksize);
int task_spawnattr_setstacksize(FAR posix_spawnattr_t *attr,
size_t stacksize);
+#else
+# define task_spawnattr_getstackaddr(fa, addr) (*(addr) = NULL, 0)
+# define task_spawnattr_setstackaddr(fa) (0)
+# define task_spawnattr_getstacksize(fa, size) (*(size) = 0, 0)
Review Comment:
Why `, 0` is needed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #7327: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #7327:
URL: https://github.com/apache/incubator-nuttx/pull/7327#discussion_r996436973
##########
include/spawn.h:
##########
@@ -216,6 +217,12 @@ int task_spawnattr_getstacksize(FAR const posix_spawnattr_t *attr,
FAR size_t *stacksize);
int task_spawnattr_setstacksize(FAR posix_spawnattr_t *attr,
size_t stacksize);
+#else
+# define task_spawnattr_getstackaddr(fa, addr) (*(addr) = NULL, 0)
+# define task_spawnattr_setstackaddr(fa) (0)
+# define task_spawnattr_getstacksize(fa, size) (*(size) = 0, 0)
Review Comment:
need return 0 to indicate success
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] pkarashchenko merged pull request #7327: sched/spawn: Add the dummy task_spawnattr_xxxstackyyy in the kernel mode
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #7327:
URL: https://github.com/apache/incubator-nuttx/pull/7327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org