You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/18 20:28:55 UTC

[GitHub] [airflow] jens-scheffler-bosch opened a new pull request, #27119: Correct the JSON style used for Run config in Grid View

jens-scheffler-bosch opened a new pull request, #27119:
URL: https://github.com/apache/airflow/pull/27119

   This PR correct the visual display of the *new* Run config view in GRID view (I like this!) which I saw appeatring on the dev branch. unfortunately it is generating white text on white background, this PR proposed to switch to default theme so that dumped JSON gets readable.
   
   Before (Using Firefox, "Light" mode:
   - JSON Keys are white text on white background (Unable to upload screenshot :-( )
   
   After this PR:
   - Black text on white background (=readable)
   - Root element of the Dict is hidden "wars printed as "root" before


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] jens-scheffler-bosch commented on pull request #27119: Correct the JSON style used for Run config in Grid View

Posted by GitBox <gi...@apache.org>.

jens-scheffler-bosch commented on PR #27119:
URL: https://github.com/apache/airflow/pull/27119#issuecomment-1282973107

   +1 why I like the *new* feature in general, cool display!
   ![image](https://user-images.githubusercontent.com/95105677/196539086-59c5c55f-3853-4953-90e4-007162a0de37.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] bbovenzi merged pull request #27119: Correct the JSON style used for Run config in Grid View

Posted by GitBox <gi...@apache.org>.

bbovenzi merged PR #27119:
URL: https://github.com/apache/airflow/pull/27119


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org