[jira] [Commented] (HBASE-23792) [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState

["Nick Dimiduk (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-23792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17030118#comment-17030118 ] 

Nick Dimiduk commented on HBASE-23792:
--------------------------------------

I can't repro this locally or find a source for the filesystem implementation getting flipped to a distributed fs. However, the only place in Hadoop code where I see this "Wrong FS" message thrown as an {{IllegalArgumentException}} is in {{FileSystem#checkPath}}.

Looking closer at the xml report, I see that the test failed once with the above. Surefire tried to re-run it, but it failed the rerun with

{noformat}
java.io.IOException: Target file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1/tableWithRefsV1 is a directory
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:105)
	at org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
{noformat}

which implies to me that when surefire reruns a test method, it does not run the BeforeClass business.

I also notice that the test method runs the same code twice, but both times it's using {{createSnapshotV2}}... I think one of the invocations is supposed to be calling {{createSnapshotV1}}.

So.
# Survive flakey rerunning by converting the static {{BeforeClass}} stuff into instance-level {{Before}}.
# Break the test method into two, one for running over each of the snapshot manifest versions.

> [Flakey Test] TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState
> -----------------------------------------------------------------------------------
>
>                 Key: HBASE-23792
>                 URL: https://issues.apache.org/jira/browse/HBASE-23792
>             Project: HBase
>          Issue Type: Test
>          Components: test
>    Affects Versions: 2.3.0
>            Reporter: Nick Dimiduk
>            Priority: Major
>         Attachments: TEST-org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.xml
>
>
> {{TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState}} fails with
> {noformat}
> java.lang.IllegalArgumentException: Wrong FS: file:/home/jenkins/jenkins-slave/workspace/HBase_Nightly_branch-2@2/component/hbase-mapreduce/target/test-data/878a5107-35a3-90ea-50ef-d2a3c32a50dc/.hbase-snapshot/tableWithRefsV1, expected: hdfs://localhost:44609
> 	at org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:110)
> 	at org.apache.hadoop.hbase.snapshot.TestExportSnapshotNoCluster.testSnapshotWithRefsExportFileSystemState(TestExportSnapshotNoCluster.java:90)
> {noformat}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)