You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2026/04/30 15:56:59 UTC

[PR] CAMEL-23220: Replace Thread.sleep() with Awaitility in camel-atom tests [camel]

gnodet opened a new pull request, #22875:
URL: https://github.com/apache/camel/pull/22875

   [CAMEL-23220](https://issues.apache.org/jira/browse/CAMEL-23220)
   
   Replace `Thread.sleep()` calls with proper asynchronous assertions in three camel-atom idempotency test files, per project coding standards.
   
   ## Changes
   
   - **AtomGoodBlogDefaultIdempotencyTest**: Replaced `Thread.sleep(5000)` + `expectedMessageCount` + `assertIsSatisfied` with Awaitility `await().atMost(10, SECONDS).untilAsserted(...)`
   - **AtomGoodBlogsRepositoryItempotencyTest**: Removed redundant `Thread.sleep(3000)` before `assertIsSatisfied`; increased `assertIsSatisfied` timeout to 10s (it polls internally)
   - **AtomGoodBlogsRepositoryItempotencyCustomRepositoryTest**: Same fix as above
   
   ## Test plan
   
   - [x] `mvn test -B -pl components/camel-atom` — all 33 tests pass
   - [x] `mvn formatter:format impsort:sort -B -pl components/camel-atom` — no formatting changes needed


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23220: Replace Thread.sleep() with Awaitility in camel-atom tests [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22875:
URL: https://github.com/apache/camel/pull/22875#issuecomment-4354154675

   <!-- ci-tested-modules -->
   :test_tube: **CI tested the following changed modules:**
   
   - `components/camel-atom`
   
   <details><summary>All tested modules (9 modules)</summary>
   
   - Camel :: Atom
   - Camel :: JBang :: MCP
   - Camel :: JBang :: Plugin :: Route Parser
   - Camel :: JBang :: Plugin :: TUI
   - Camel :: JBang :: Plugin :: Validate
   - Camel :: Launcher :: Container
   - Camel :: RSS
   - Camel :: YAML DSL :: Validator
   - Camel :: YAML DSL :: Validator Maven Plugin
   
   </details>
   
   ---
   :gear: [View full build and test results](https://github.com/apache/camel/actions/runs/25175575444)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23220: Replace Thread.sleep() with Awaitility in camel-atom tests [camel]

Posted by "davsclaus (via GitHub)" <gi...@apache.org>.
davsclaus merged PR #22875:
URL: https://github.com/apache/camel/pull/22875


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] CAMEL-23220: Replace Thread.sleep() with Awaitility in camel-atom tests [camel]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #22875:
URL: https://github.com/apache/camel/pull/22875#issuecomment-4354018182

   :star2: Thank you for your contribution to the Apache Camel project! :star2:
     :robot: CI automation will test this PR automatically.
   
     :camel: Apache Camel Committers, please review the following items:
   
     * First-time contributors **require MANUAL approval** for the GitHub Actions to run
     * You can use the command `/component-test (camel-)component-name1 (camel-)component-name2..` to request a test from the test bot although they are normally detected and executed by CI.
     * You can label PRs using `skip-tests` and `test-dependents` to fine-tune the checks executed by this PR.
     * Build and test logs are available in the summary page. **Only** [Apache Camel committers](https://camel.apache.org/community/team/#committers) have access to the summary.
     
     :warning: Be careful when sharing logs. Review their contents before sharing them publicly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org