[GitHub] [flink] slinkydeveloper commented on a diff in pull request #19414: [FLINK 26389][tests] update deprecated operators in e2e tests

[GitBox <gi...@apache.org>]

slinkydeveloper commented on code in PR #19414:
URL: https://github.com/apache/flink/pull/19414#discussion_r847067704


##########
flink-end-to-end-tests/flink-distributed-cache-via-blob-test/src/main/java/org/apache/flink/streaming/tests/DistributedCacheViaBlobTestProgram.java:
##########
@@ -65,7 +67,11 @@ public static void main(String[] args) throws Exception {
                                 Files.size(inputFile),
                                 inputDir.toAbsolutePath().toString(),
                                 containedFile.getFileName().toString()))
-                .writeAsText(params.getRequired("output"), FileSystem.WriteMode.OVERWRITE);
+                .sinkTo(
+                        FileSink.forRowFormat(
+                                        new org.apache.flink.core.fs.Path(outputPath),

Review Comment:
   Remove the FQCN here



##########
flink-end-to-end-tests/flink-stream-stateful-job-upgrade-test/src/main/java/org/apache/flink/streaming/tests/StatefulStreamJobUpgradeTestProgram.java:
##########
@@ -90,11 +92,13 @@ public static void main(String[] args) throws Exception {
 
     private static void executeOriginalVariant(StreamExecutionEnvironment env, ParameterTool pt)
             throws Exception {
+        Duration maxOutOfOrderness = extractTimestamp(pt);
         KeyedStream<Event, Integer> source =
                 env.addSource(createEventSource(pt))
                         .name("EventSource")
                         .uid("EventSource")
-                        .assignTimestampsAndWatermarks(createTimestampExtractor(pt))
+                        .assignTimestampsAndWatermarks(
+                                WatermarkStrategy.forBoundedOutOfOrderness(maxOutOfOrderness))

Review Comment:
   After this method invocation you still need the watermark assigner here I think, same below, using the `createTimestampExtractor`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org