You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/10/17 00:41:53 UTC

[GitHub] [submarine] woodcutter-eric opened a new pull request #780: SUBMARINE-1055. Use builder pattern to simplify construction of controller

woodcutter-eric opened a new pull request #780:
URL: https://github.com/apache/submarine/pull/780


   ### What is this PR for?
   <!-- A few sentences describing the overall goals of the pull request's commits.
   First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
   -->
   
   Now, the construction of controller is bulky. It needs a lot of arguments when making a new instance. We may use builder design pattern to solve this problem to make code more cleaner.
   
   ### What type of PR is it?
   [mprovement | Refactoring]
   
   ### Todos
   * [x] - Use builder pattern to reduce the number of parameters of NewController
   * [x] - Replace NewController with a higher level wrapper function
   * [x] - Partition initialization logic in the creation of a controller
   * [x] - Decouple event register and setup 
   
   ### What is the Jira issue?
   <!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
   * Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
   -->
   
   https://issues.apache.org/jira/projects/SUBMARINE/issues/SUBMARINE-1055
   
   ### How should this be tested?
   <!--
   * First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   -->
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] woodcutter-eric commented on pull request #780: SUBMARINE-1055. Use builder pattern to simplify construction of controller

Posted by GitBox <gi...@apache.org>.
woodcutter-eric commented on pull request #780:
URL: https://github.com/apache/submarine/pull/780#issuecomment-948675162


   Need some fix again after some discussion. Please delay merge!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] woodcutter-eric commented on pull request #780: SUBMARINE-1055. Use builder pattern to simplify construction of controller

Posted by GitBox <gi...@apache.org>.
woodcutter-eric commented on pull request #780:
URL: https://github.com/apache/submarine/pull/780#issuecomment-951543433


   > Need some fix again after some discussion. Please delay merge!
   
   Now it is fixed!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] asfgit closed pull request #780: SUBMARINE-1055. Use builder pattern to simplify construction of controller

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #780:
URL: https://github.com/apache/submarine/pull/780


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@submarine.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org