You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "Bryce Ewing (JIRA)" <ji...@apache.org> on 2008/06/25 07:56:45 UTC

[jira] Created: (SLING-556) Freemarker wrapper not correctly dereferencing multi value properties

Freemarker wrapper not correctly dereferencing multi value properties
---------------------------------------------------------------------

                 Key: SLING-556
                 URL: https://issues.apache.org/jira/browse/SLING-556
             Project: Sling
          Issue Type: Bug
          Components: Scripting
    Affects Versions: 2.0.0
            Reporter: Bryce Ewing
            Priority: Minor
         Attachments: freemarker.patch

When iterating through multi value properties of type Reference the NodeModel was not dereferencing the node reference when the property was being treated as a node list, i.e.:
    <list node.@multireferenceproperty as reference>...</list>
Correctly lists through all the reference properties as properties, but:
    <list node.multireferenceproperty as reference>...</list>
Throws an exception.  This should iterate over the property reference values, find the node and make the node available as reference within the body of the list markup.

Patch included to fix this, and tests included to test for both cases above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SLING-556) Freemarker wrapper not correctly dereferencing multi value properties

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertrand Delacretaz reassigned SLING-556:
-----------------------------------------

    Assignee: Bertrand Delacretaz

> Freemarker wrapper not correctly dereferencing multi value properties
> ---------------------------------------------------------------------
>
>                 Key: SLING-556
>                 URL: https://issues.apache.org/jira/browse/SLING-556
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: 2.0.0
>            Reporter: Bryce Ewing
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: freemarker.patch
>
>
> When iterating through multi value properties of type Reference the NodeModel was not dereferencing the node reference when the property was being treated as a node list, i.e.:
>     <list node.@multireferenceproperty as reference>...</list>
> Correctly lists through all the reference properties as properties, but:
>     <list node.multireferenceproperty as reference>...</list>
> Throws an exception.  This should iterate over the property reference values, find the node and make the node available as reference within the body of the list markup.
> Patch included to fix this, and tests included to test for both cases above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SLING-556) Freemarker wrapper not correctly dereferencing multi value properties

Posted by "Bertrand Delacretaz (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bertrand Delacretaz resolved SLING-556.
---------------------------------------

    Resolution: Fixed

Patch applied in revision 671465, thanks very much!

Please cross-check and close this issue if ok.

Creating a new issue was the right thing to do, personally I prefer small focused issues.


> Freemarker wrapper not correctly dereferencing multi value properties
> ---------------------------------------------------------------------
>
>                 Key: SLING-556
>                 URL: https://issues.apache.org/jira/browse/SLING-556
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: 2.0.0
>            Reporter: Bryce Ewing
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: freemarker.patch
>
>
> When iterating through multi value properties of type Reference the NodeModel was not dereferencing the node reference when the property was being treated as a node list, i.e.:
>     <list node.@multireferenceproperty as reference>...</list>
> Correctly lists through all the reference properties as properties, but:
>     <list node.multireferenceproperty as reference>...</list>
> Throws an exception.  This should iterate over the property reference values, find the node and make the node available as reference within the body of the list markup.
> Patch included to fix this, and tests included to test for both cases above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SLING-556) Freemarker wrapper not correctly dereferencing multi value properties

Posted by "Bryce Ewing (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SLING-556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12607864#action_12607864 ] 

Bryce Ewing commented on SLING-556:
-----------------------------------

As an aside, I was wondering whether an issue like this should be created new, or whether I should have reopened the last issue?

> Freemarker wrapper not correctly dereferencing multi value properties
> ---------------------------------------------------------------------
>
>                 Key: SLING-556
>                 URL: https://issues.apache.org/jira/browse/SLING-556
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: 2.0.0
>            Reporter: Bryce Ewing
>            Priority: Minor
>         Attachments: freemarker.patch
>
>
> When iterating through multi value properties of type Reference the NodeModel was not dereferencing the node reference when the property was being treated as a node list, i.e.:
>     <list node.@multireferenceproperty as reference>...</list>
> Correctly lists through all the reference properties as properties, but:
>     <list node.multireferenceproperty as reference>...</list>
> Throws an exception.  This should iterate over the property reference values, find the node and make the node available as reference within the body of the list markup.
> Patch included to fix this, and tests included to test for both cases above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (SLING-556) Freemarker wrapper not correctly dereferencing multi value properties

Posted by "Bryce Ewing (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryce Ewing closed SLING-556.
-----------------------------


Tested and works correctly.

> Freemarker wrapper not correctly dereferencing multi value properties
> ---------------------------------------------------------------------
>
>                 Key: SLING-556
>                 URL: https://issues.apache.org/jira/browse/SLING-556
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: 2.0.0
>            Reporter: Bryce Ewing
>            Assignee: Bertrand Delacretaz
>            Priority: Minor
>         Attachments: freemarker.patch
>
>
> When iterating through multi value properties of type Reference the NodeModel was not dereferencing the node reference when the property was being treated as a node list, i.e.:
>     <list node.@multireferenceproperty as reference>...</list>
> Correctly lists through all the reference properties as properties, but:
>     <list node.multireferenceproperty as reference>...</list>
> Throws an exception.  This should iterate over the property reference values, find the node and make the node available as reference within the body of the list markup.
> Patch included to fix this, and tests included to test for both cases above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SLING-556) Freemarker wrapper not correctly dereferencing multi value properties

Posted by "Bryce Ewing (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SLING-556?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryce Ewing updated SLING-556:
------------------------------

    Attachment: freemarker.patch

> Freemarker wrapper not correctly dereferencing multi value properties
> ---------------------------------------------------------------------
>
>                 Key: SLING-556
>                 URL: https://issues.apache.org/jira/browse/SLING-556
>             Project: Sling
>          Issue Type: Bug
>          Components: Scripting
>    Affects Versions: 2.0.0
>            Reporter: Bryce Ewing
>            Priority: Minor
>         Attachments: freemarker.patch
>
>
> When iterating through multi value properties of type Reference the NodeModel was not dereferencing the node reference when the property was being treated as a node list, i.e.:
>     <list node.@multireferenceproperty as reference>...</list>
> Correctly lists through all the reference properties as properties, but:
>     <list node.multireferenceproperty as reference>...</list>
> Throws an exception.  This should iterate over the property reference values, find the node and make the node available as reference within the body of the list markup.
> Patch included to fix this, and tests included to test for both cases above.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.