You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2016/08/14 12:06:44 UTC
[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file
Hello Todd Lipcon,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/3972
to review the following change.
Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file
......................................................................
Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file
We can use this in several places now.
Change-Id: I1bbe92375ca72c162eba72004cb0c255ec74b5ca
---
A src/kudu/fs/block_manager-test-util.h
M src/kudu/fs/block_manager-test.cc
2 files changed, 32 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/3972/1
--
To view, visit http://gerrit.cloudera.org:8080/3972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1bbe92375ca72c162eba72004cb0c255ec74b5ca
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change.
Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/3972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bbe92375ca72c162eba72004cb0c255ec74b5ca
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/2870/
--
To view, visit http://gerrit.cloudera.org:8080/3972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1bbe92375ca72c162eba72004cb0c255ec74b5ca
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Pull RETURN NOT LOG BLOCK MANAGER macro into its own file
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: Pull RETURN_NOT_LOG_BLOCK_MANAGER macro into its own file
......................................................................
Abandoned
This might not be needed
--
To view, visit http://gerrit.cloudera.org:8080/3972
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I1bbe92375ca72c162eba72004cb0c255ec74b5ca
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>