You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tuscany.apache.org by an...@apache.org on 2007/05/08 12:18:09 UTC

svn commit: r536148 - /incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java

Author: antelder
Date: Tue May  8 03:18:01 2007
New Revision: 536148

URL: http://svn.apache.org/viewvc?view=rev&rev=536148
Log:
Remove getImplementationInterfaceContract from ImplementationProvider interface as nothing is using it

Modified:
    incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java

Modified: incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java
URL: http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java?view=diff&rev=536148&r1=536147&r2=536148
==============================================================================
--- incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java (original)
+++ incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java Tue May  8 03:18:01 2007
@@ -20,7 +20,6 @@
 package org.apache.tuscany.provider;
 
 import org.apache.tuscany.core.RuntimeComponentService;
-import org.apache.tuscany.interfacedef.InterfaceContract;
 import org.apache.tuscany.interfacedef.Operation;
 import org.apache.tuscany.invocation.Invoker;
 
@@ -53,13 +52,4 @@
      */
     Invoker createCallbackInvoker(Operation operation);
     
-    /**
-     * Get the effective interface contract imposed by the implementation.
-     * 
-     * @param service The component service
-     * @return The effective interface contract, if null is returned, the interface contract
-     * for the component service will be used
-     */
-    InterfaceContract getImplementationInterfaceContract(RuntimeComponentService service);
-  
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-commits-help@ws.apache.org

Re: svn commit: r536148 - /incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java

Posted by ant elder <an...@gmail.com>.
I'd also like to remove the getImplementationInterfaceContract method from
the ReferenceBindingProvider and ServiceBindingProvider interfaces as well
as nothing seems to do anything useful with them, but now I wonder if I'm
missing something. Is there a good reason why this method still need to be
on those interfaces?

   ...ant

On 5/8/07, antelder@apache.org <an...@apache.org> wrote:
>
> Author: antelder
> Date: Tue May  8 03:18:01 2007
> New Revision: 536148
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=536148
> Log:
> Remove getImplementationInterfaceContract from ImplementationProvider
> interface as nothing is using it
>
> Modified:
>
>     incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java
>
> Modified:
> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java
> URL:
> http://svn.apache.org/viewvc/incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java?view=diff&rev=536148&r1=536147&r2=536148
>
> ==============================================================================
> ---
> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java
> (original)
> +++
> incubator/tuscany/java/sca/modules/core-spi/src/main/java/org/apache/tuscany/provider/ImplementationProvider.java
> Tue May  8 03:18:01 2007
> @@ -20,7 +20,6 @@
> package org.apache.tuscany.provider;
>
> import org.apache.tuscany.core.RuntimeComponentService;
> -import org.apache.tuscany.interfacedef.InterfaceContract;
> import org.apache.tuscany.interfacedef.Operation;
> import org.apache.tuscany.invocation.Invoker;
>
> @@ -53,13 +52,4 @@
>       */
>      Invoker createCallbackInvoker(Operation operation);
>
> -    /**
> -     * Get the effective interface contract imposed by the
> implementation.
> -     *
> -     * @param service The component service
> -     * @return The effective interface contract, if null is returned, the
> interface contract
> -     * for the component service will be used
> -     */
> -    InterfaceContract
> getImplementationInterfaceContract(RuntimeComponentService service);
> -
> }
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-commits-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-commits-help@ws.apache.org
>
>