You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/09/01 14:04:02 UTC
[GitHub] [incubator-doris] Astralidea opened a new pull request #4504: Support SELECT Optimizer Hints SET_VAR
Astralidea opened a new pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504
## Proposed changes
Fix #4503
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [] Bugfix (non-breaking change which fixes an issue)
- [x] New feature (non-breaking change which adds functionality)
- [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [] Documentation Update (if none of the other choices apply)
- [] Code refactor (Modify the code structure, format the code, etc...)
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
- [x] Compiling and unit tests pass locally with my changes
- [] I have added tests that prove my fix is effective or that my feature works
- [] If this change need a document change, I have updated the document
- [] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
代码可能写得不优雅,看看怎么去解决这个问题比较好。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-686884247
> > @Astralidea Good job!. Please add a UT.
>
> 好的。UT我之前看了一下,貌似不太好加,我得想想怎么加。
或许可以把你的逻辑加到SelectStmt 的 analyze 方法里面,这样 SelectStmtTest 就可以直接测试,确认session 变量是否生效。
不过需要注意 context.getSessionVariable().toThrift() 要在 SelectStmt.analyze(analyzer) 之后,你可以试下。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Astralidea edited a comment on pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
Astralidea edited a comment on pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-686374560
> Hi @Astralidea
> Thanks for your contribution, and could you please update the document?
> I think you can put it in `docs/en/administrator-guide/variables.md` and `docs/zh-CN/administrator-guide/variables.md`.
> For English, you can rely on translate.google.com
I have updated the document, you can see if there is any need to change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] kangkaisen commented on pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
kangkaisen commented on pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-686877018
@Astralidea Good job!. Please add a UT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Astralidea commented on pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
Astralidea commented on pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-687249565
> > > @Astralidea Good job!. Please add a UT.
> >
> >
> > 好的。UT我之前看了一下,貌似不太好加,我得想想怎么加。
>
> 或许可以把你的逻辑加到SelectStmt 的 analyze 方法里面,这样 SelectStmtTest 就可以直接测试,确认session 变量是否生效。
>
> 不过需要注意 context.getSessionVariable().toThrift() 要在 SelectStmt.analyze(analyzer) 之后,你可以试下。
我改写一下DorisAssert框架可以测了。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Astralidea commented on pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
Astralidea commented on pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-686374560
> Hi @Astralidea
> Thanks for your contribution, and could you please update the document?
> I think you can put it in `docs/en/administrator-guide/variables.md` and `docs/zh-CN/administrator-guide/variables.md`.
> For English, you can rely on translate.google.com
No Problem, I will Documentation Update later and soon.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] chaoyli commented on pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
chaoyli commented on pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-686328723
A good job
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
morningman commented on pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-686356768
Hi @Astralidea
Thanks for your contribution, and could you please update the document?
I think you can put it in `docs/en/administrator-guide/variables.md` and `docs/zh-CN/administrator-guide/variables.md`.
For English, you can rely on translate.google.com
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] Astralidea commented on pull request #4504: [Feature]Support SELECT Optimizer Hints SET_VAR
Posted by GitBox <gi...@apache.org>.
Astralidea commented on pull request #4504:
URL: https://github.com/apache/incubator-doris/pull/4504#issuecomment-686880108
> @Astralidea Good job!. Please add a UT.
好的。UT我之前看了一下,貌似不太好加,我得想想怎么加。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org