You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Norbert Luksa (Code Review)" <ge...@cloudera.org> on 2019/10/09 09:04:07 UTC
[Impala-ASF-CR] IMPALA-6501: Optimize count(star) for Kudu scans
Norbert Luksa has posted comments on this change. ( http://gerrit.cloudera.org:8080/14347 )
Change subject: IMPALA-6501: Optimize count(star) for Kudu scans
......................................................................
Patch Set 5:
(7 comments)
http://gerrit.cloudera.org:8080/#/c/14347/5//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/14347/5//COMMIT_MSG@7
PS5, Line 7: IMPALA-8498
> this seems to be a different Jira
Done
http://gerrit.cloudera.org:8080/#/c/14347/5/be/src/exec/kudu-scan-node-base.h
File be/src/exec/kudu-scan-node-base.h:
http://gerrit.cloudera.org:8080/#/c/14347/5/be/src/exec/kudu-scan-node-base.h@45
PS5, Line 45:
: bool optimize_count_star() const { return optimize_count_star_; }
> optional: replace with count_star_slot_offset_ != -1
Done
Should I also change the logic in hdfs-scan-node-base?
http://gerrit.cloudera.org:8080/#/c/14347/5/be/src/exec/kudu-scanner.cc
File be/src/exec/kudu-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/14347/5/be/src/exec/kudu-scanner.cc@117
PS5, Line 117: Tuple* dst_tuple = reinterpret_cast<Tuple*>(tuple_buffer);
> Is there a reason for creating this variable once more?
Nothing particular, moved inside the loop.
http://gerrit.cloudera.org:8080/#/c/14347/5/be/src/exec/kudu-scanner.cc@118
PS5, Line 118: while
> optional: the while block could go to a different function
Done
http://gerrit.cloudera.org:8080/#/c/14347/5/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java
File fe/src/main/java/org/apache/impala/planner/KuduScanNode.java:
http://gerrit.cloudera.org:8080/#/c/14347/5/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@154
PS5, Line 154:
> nit: extra line
Done
http://gerrit.cloudera.org:8080/#/c/14347/5/fe/src/main/java/org/apache/impala/planner/KuduScanNode.java@366
PS5, Line 366:
> nit: extra line
Done
http://gerrit.cloudera.org:8080/#/c/14347/5/fe/src/main/java/org/apache/impala/planner/ScanNode.java
File fe/src/main/java/org/apache/impala/planner/ScanNode.java:
http://gerrit.cloudera.org:8080/#/c/14347/5/fe/src/main/java/org/apache/impala/planner/ScanNode.java@72
PS5, Line 72: // use the
> nit: line brakes could be prettier
Done
--
To view, visit http://gerrit.cloudera.org:8080/14347
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic99e0f954d0ca65779bd531ca79ace1fcb066fb9
Gerrit-Change-Number: 14347
Gerrit-PatchSet: 5
Gerrit-Owner: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Norbert Luksa <no...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Wed, 09 Oct 2019 09:04:07 +0000
Gerrit-HasComments: Yes