[GitHub] [flink] LoveHeat commented on a diff in pull request #22808: [FLINK-32316] [SourceAlignment] Scheduling announceCombinedWatermark period task during SourceCoordinator::start not in construct function to avoid duplicated task be scheduled

["LoveHeat (via GitHub)" <gi...@apache.org>]

LoveHeat commented on code in PR #22808:
URL: https://github.com/apache/flink/pull/22808#discussion_r1240645568


##########
flink-runtime/src/test/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorAlignmentTest.java:
##########
@@ -131,6 +136,73 @@ void testWatermarkAlignmentWithTwoGroups() throws Exception {
         }
     }
 
+    /**
+     * When JobManager failover and auto recover job, SourceCoordinator will reset twice: 1. Create
+     * JobMaster --> Create Scheduler --> Create DefaultExecutionGraph --> Init
+     * SourceCoordinator(but will not start it) 2. JobMaster call
+     * restoreLatestCheckpointedStateInternal, which will call {@link
+     * org.apache.flink.runtime.operators.coordination.RecreateOnResetOperatorCoordinator#resetToCheckpoint(long,byte[])}
+     * and reset SourceCoordinator. Because the first SourceCoordinator is not be started, so the
+     * period task can't be stopped.
+     */
+    @Test
+    void testSourceCoordinatorReset() throws Exception {

Review Comment:
   yeah, done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org