You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/12/22 00:11:19 UTC
[jira] [Commented] (GEODE-4154) Remove
GemFireCacheImpl.getInstance() calls from geode-wan module.
[ https://issues.apache.org/jira/browse/GEODE-4154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16300753#comment-16300753 ]
ASF GitHub Bot commented on GEODE-4154:
---------------------------------------
nabarunnag opened a new pull request #1201: GEODE-4154: Removed GemFireCacheImpl.getInstance
URL: https://github.com/apache/geode/pull/1201
* Refactored the test code so that GemFireCacheImpl.getInstance is nolonger called.
* Upgraded the WANTestBase to use LogService than LoggerServiceUtils.
* Optimized the imports.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and
submit an update to your PR as soon as possible. If you need help, please send an
email to dev@geode.apache.org.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Remove GemFireCacheImpl.getInstance() calls from geode-wan module.
> ------------------------------------------------------------------
>
> Key: GEODE-4154
> URL: https://issues.apache.org/jira/browse/GEODE-4154
> Project: Geode
> Issue Type: Sub-task
> Components: wan
> Reporter: nabarun
> Assignee: nabarun
>
> Refactor the wan module code so that it doesn't use calls to GemFireCacheImpl.getInstance() to get access to the cache.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)