[GitHub] [nifi] alfprado commented on a change in pull request #4683: NIFI-8029 Adding StringEscapeUtils.escapeJava() to correct value with…

[GitBox <gi...@apache.org>]

alfprado commented on a change in pull request #4683:
URL: https://github.com/apache/nifi/pull/4683#discussion_r528963481



##########
File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##########
@@ -1122,7 +1123,7 @@ public long contentLength() {
 
         final ComponentLog logger = getLogger();
         for (String headerKey : dynamicPropertyNames) {
-            String headerValue = context.getProperty(headerKey).evaluateAttributeExpressions(requestFlowFile).getValue();
+            String headerValue = StringEscapeUtils.escapeJava(context.getProperty(headerKey).evaluateAttributeExpressions(requestFlowFile).getValue());

Review comment:
        I'm new in NIFI and I don't know it very well, I just open it because I'm developing a new custom processor for my personal purpose that use invokehttp as base and in my context I thought it was the best solution. I was thought it was a bug but you are right. Thank you for the explanation




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org