You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geaflow.apache.org by "kitalkuyo-gita (via GitHub)" <gi...@apache.org> on 2026/08/22 01:38:50 UTC
[I] [Geaflow/ai-memory] Define `DocumentSource` and `DocumentRecord` contracts [geaflow]
kitalkuyo-gita opened a new issue, #833:
URL: https://github.com/apache/geaflow/issues/833
Priority: P0
Difficulty: Starter
Suggested labels: `area:ai-memory`, `type:contract`, `difficulty:starter`
Context: `TextFileReader` currently reads non-empty lines into strings. Graph Memory Phase 1 needs a stable document boundary before chunking, extraction, indexing, and replay can be deterministic.
Scope:
- Add contract classes for `DocumentSource`, `DocumentRecord`, and `SourceRef`.
- Include fields such as `source_id`, `uri`, `media_type`, `charset`, `content_hash`, `created_at`, `ingested_at`, and `metadata`.
- Add tests for empty files, duplicate source IDs, Unicode content, and stable content hash.
Constraints:
- Do not replace all existing readers in this issue.
- Do not add remote storage support.
- Do not store raw private text in logs.
Acceptance Criteria:
- A document loaded twice with the same content receives the same `content_hash`.
- Invalid or missing source metadata fails with a typed validation error.
- Existing `TextFileReader` tests remain compatible.
Suggested paths:
- `geaflow-ai/src/main/java/org/apache/geaflow/ai/graph/io`
- `geaflow-ai/src/test/java/org/apache/geaflow/ai`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [I] [Geaflow/ai-memory] Define `DocumentSource` and `DocumentRecord` contracts [geaflow]
Posted by "E2ern1ty (via GitHub)" <gi...@apache.org>.
E2ern1ty commented on issue #833:
URL: https://github.com/apache/geaflow/issues/833#issuecomment-5377846703
Hi, I'd like to work on this issue.
Plan:
- Add `DocumentSource`, `DocumentRecord` and `SourceRef` contracts under `geaflow-ai/src/main/java/org/apache/geaflow/ai/graph/io`
- Implement stable `content_hash` (same content loaded twice yields the same hash) and typed validation errors for invalid/missing metadata
- Add tests covering empty files, duplicate source IDs, Unicode content, and hash stability, keeping existing `TextFileReader` tests untouched
I'll submit a PR once ready. Feedback on the approach is welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org
Re: [I] [Geaflow/ai-memory] Define `DocumentSource` and `DocumentRecord` contracts [geaflow]
Posted by "kitalkuyo-gita (via GitHub)" <gi...@apache.org>.
kitalkuyo-gita commented on issue #833:
URL: https://github.com/apache/geaflow/issues/833#issuecomment-5389753601
> Hi, I'd like to work on this issue.
>
> Plan:
>
> * Add `DocumentSource`, `DocumentRecord` and `SourceRef` contracts under `geaflow-ai/src/main/java/org/apache/geaflow/ai/graph/io`
> * Implement stable `content_hash` (same content loaded twice yields the same hash) and typed validation errors for invalid/missing metadata
> * Add tests covering empty files, duplicate source IDs, Unicode content, and hash stability, keeping existing `TextFileReader` tests untouched
>
> I'll submit a PR once ready. Feedback on the approach is welcome.
Okay, I'm taking a weekend off. It's great to see you're willing to take on this question; your contribution is welcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@geaflow.apache.org
For additional commands, e-mail: issues-help@geaflow.apache.org