[GitHub] [iceberg] pvary commented on a change in pull request #2362: Spark: Pass Table object to executors

[GitBox <gi...@apache.org>]

pvary commented on a change in pull request #2362:
URL: https://github.com/apache/iceberg/pull/2362#discussion_r600332942



##########
File path: core/src/main/java/org/apache/iceberg/StaticTable.java
##########
@@ -0,0 +1,262 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.apache.iceberg;
+
+import java.io.Serializable;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import org.apache.iceberg.encryption.EncryptionManager;
+import org.apache.iceberg.io.FileIO;
+import org.apache.iceberg.io.LocationProvider;
+import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+
+// TODO: any ideas on naming?
+public class StaticTable implements Table, Serializable {

Review comment:
       One of the main goals of the `BaseTable` serialization was to create a way to start scans on the deserialized Table. You can see here the example:
   https://github.com/apache/iceberg/blob/23735d1d99abf0207543ff5d9dcb63ae4fe4ec02/mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergInputFormat.java#L97-L104
   
   Maybe we can have Lazy loading of the metadata when needed and that way we can merge the two approach.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org