[GitHub] [fineract] rahulg963 commented on a change in pull request #1817: datatable field added in client swagger resource (FINERACT-1363)

[GitBox <gi...@apache.org>]

rahulg963 commented on a change in pull request #1817:
URL: https://github.com/apache/fineract/pull/1817#discussion_r685392745



##########
File path: fineract-provider/src/main/java/org/apache/fineract/portfolio/client/api/ClientsApiResourceSwagger.java
##########
@@ -240,6 +241,17 @@ private GetClientsTimeline() {}
 
         private PostClientsRequest() {}
 
+        static final class PostClientsDatatable {
+
+            private PostClientsDatatable() {}
+
+            @Schema(example = "Client Beneficiary information")
+            public String registeredTableName;
+            @Schema(example = "data")
+            public HashMap<String, Object> data;

Review comment:
       Instead of HashMap, shouldn't be another class having fields such as "LastName": string, "Relationship": string, "dateFormat ": string ... etc? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org