[jira] [Commented] (HDFS-929) DFSClient#getBlockSize is unused

["Harsh J (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HDFS-929?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13178116#comment-13178116 ] 

Harsh J commented on HDFS-929:
------------------------------

Thanks for the careful eye Jim!

This is provided by the ClientProtocol. If it is being deprecated, it should be deprecated all the way, and removed at a subsequent release. This'd incur an unwanted change in compatibility and will make HDFS require major version upgrade. So far, I only see server-side mechanisms use this via the {{INodeFile#getPreferredBlockSize(…)}} method that eventually gets called, and this is called pretty directly.

I do not know why its published into the client (seems to be available since very long ago) but there's no harm in keeping it as DFSClient was never meant for user consumption. Perhaps a feature that may get added later may use it?

If you agree with this assessment, lets resolve this one.
                
> DFSClient#getBlockSize is unused
> --------------------------------
>
>                 Key: HDFS-929
>                 URL: https://issues.apache.org/jira/browse/HDFS-929
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Eli Collins
>            Assignee: Jim Plush
>            Priority: Minor
>             Fix For: 0.24.0
>
>         Attachments: HDFS-929-take1.txt
>
>
> DFSClient#getBlockSize is unused. Since it's a public class internal to HDFS we just remove it? If not then we should add a unit test.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira