You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/07 10:28:48 UTC

[GitHub] [pulsar] Jason918 commented on a change in pull request #14545: Cancel offload tasks when managed ledger closed.

Jason918 commented on a change in pull request #14545:
URL: https://github.com/apache/pulsar/pull/14545#discussion_r820570563



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -2317,7 +2317,7 @@ private void maybeOffloadInBackground(CompletableFuture<PositionImpl> promise) {
 
     private void maybeOffload(CompletableFuture<PositionImpl> finalPromise) {
         if (!offloadMutex.tryLock()) {
-            scheduledExecutor.schedule(safeRun(() -> maybeOffloadInBackground(finalPromise)),
+            scheduledExecutor.schedule(safeRun(() -> maybeOffload(finalPromise)),

Review comment:
       Why do we change this？




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org