You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@iotdb.apache.org by 徐毅 <xu...@126.com> on 2019/03/03 11:41:00 UTC

Problems about rat plugin and apache header check

Hi,


Now we use rat plugin to check apache header, it seems that our project can pass rat check on linux but failed on windows.


If someone creates a pull request from his forked repo, we use travis-ci to run tests on different os without checking apache header. If we add apache header check in travis file(see [1]), it fails on some os.


Can we add a new pipeline which is only used to check apache header on linux? I found that there many free continuous integration service at [2]. Shall we choose one of them? 


[1]  https://github.com/apache/incubator-iotdb/pull/84
[2] https://github.com/marketplace/category/continuous-integration


Thanks
XuYi


Re: AW: Problems about rat plugin and apache header check

Posted by 徐毅 <xu...@126.com>.
In .travis.yml file. no matter how many os environments you configure, they all execute same commands, for example "mvn clean test".


Can we configure a special os to only run 'mvn rat:check' command while other os run 'mvn clean test'? 


On 3/3/2019 21:50,Xiangdong Huang<sa...@gmail.com> wrote:
Hi,

I am not sure whether travis can provide a separated pipeline to run
user-specified command.

What do you mean about `user-specified command`?

Best,

-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

黄向东
清华大学 软件学院


徐毅 <xu...@126.com> 于2019年3月3日周日 下午8:13写道:

Hi


When someone creates a pull request from forked repo, jenkins won't
trigger to run tests. So we use travis-ci to trigger tests on different os.
I am not sure whether travis can provide a separated pipeline to run
user-specified command.


Thanks
XuYi


On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
Hi,

this behavior sounds strange.
But I think this pipeline should be build into the Jenkins build, or?
It should be pretty easy to force one build step to a specific os.

Perhaps we should open a Jira for that issue to finally track down the
real source of the problem.

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Betreff: Problems about rat plugin and apache header check
Von: 徐毅
An: dev@iotdb.apache.org
Cc:

Hi,


Now we use rat plugin to check apache header, it seems that our project
can pass rat check on linux but failed on windows.


If someone creates a pull request from his forked repo, we use travis-ci
to run tests on different os without checking apache header. If we add
apache header check in travis file(see [1]), it fails on some os.


Can we add a new pipeline which is only used to check apache header on
linux? I found that there many free continuous integration service at [2].
Shall we choose one of them?


[1]  https://github.com/apache/incubator-iotdb/pull/84
[2] https://github.com/marketplace/category/continuous-integration


Thanks
XuYi



AW: AW: Problems about rat plugin and apache header check

Posted by Julian Feinauer <j....@pragmaticminds.de>.

Von meinem Mobiltelefon gesendet
Hi Xiangdong,

Good observation.could it be due to slashes or something?

Julian

-------- Ursprüngliche Nachricht --------
Betreff: Re: AW: Problems about rat plugin and apache header check
Von: 徐毅
An: dev@iotdb.apache.org
Cc:

It seems that `exclude` configuration does not work on windows, I run "mvn rat:check" command on win10 and jdk8.


Tha rat.txt outputs as follow:


*****************************************************
Printing headers for files without AL header...




=======================================================================
==.checkstyle
=======================================================================
<?xml version="1.0" encoding="UTF-8"?>


<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter=                                                                                                              "false">
  <local-check-config name="google" location="checkstyle.xml" type="project" des                                                                                                              cription="">
    <additional-data name="protect-config-file" value="false"/>
  </local-check-config>
  <fileset name="all" enabled="true" check-config-name="Google Checks" local="fa                                                                                                              lse">
    <file-match-pattern match-pattern="." include-pattern="true"/>
  </fileset>
</fileset-config>


=======================================================================
==.git/COMMIT_EDITMSG
=======================================================================
add debug log info for jdbc service


=======================================================================
==.git/config
=======================================================================
[core]
        repositoryformatversion = 0
        filemode = false
        bare = false
        logallrefupdates = true
        symlinks = false
        ignorecase = true
[remote "origin"]
        url = git@github.com:apache/incubator-iotdb.git
        fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
        remote = origin
        merge = refs/heads/master
[branch "doc"]
        remote = origin
        merge = refs/heads/doc
[branch "add_iotdb_env_script_test"]


On 3/3/2019 22:02,Xiangdong Huang<sa...@gmail.com> wrote:
Hi,

I notice that win-oraclejdk8, win-oraclejdk11 and linux-openjdk11 fails on
https://travis-ci.org/apache/incubator-iotdb/builds/500987110

It is easy that just skip apache-rat check on the above 3 jobs. But, I
wonder why they failed before I skip that...

Does anyone know how to print the file on Travis? Or, if someone has Win OS
with oracle jdk8/11, please run `mvn apache-rat:check` to verify the result.

[ERROR] Failed to execute goal
org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project root:
Too many files with unapproved license: 3057 See RAT report in:
C:\Users\travis\build\apache\incubator-iotdb\target\rat.txt

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

黄向东
清华大学 软件学院


Xiangdong Huang <sa...@gmail.com> 于2019年3月3日周日 下午9:50写道:

Hi,

I am not sure whether travis can provide a separated pipeline to run
user-specified command.

What do you mean about `user-specified command`?

Best,

-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

黄向东
清华大学 软件学院


徐毅 <xu...@126.com> 于2019年3月3日周日 下午8:13写道:

Hi


When someone creates a pull request from forked repo, jenkins won't
trigger to run tests. So we use travis-ci to trigger tests on different os.
I am not sure whether travis can provide a separated pipeline to run
user-specified command.


Thanks
XuYi


On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
Hi,

this behavior sounds strange.
But I think this pipeline should be build into the Jenkins build, or?
It should be pretty easy to force one build step to a specific os.

Perhaps we should open a Jira for that issue to finally track down the
real source of the problem.

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Betreff: Problems about rat plugin and apache header check
Von: 徐毅
An: dev@iotdb.apache.org
Cc:

Hi,


Now we use rat plugin to check apache header, it seems that our project
can pass rat check on linux but failed on windows.


If someone creates a pull request from his forked repo, we use travis-ci
to run tests on different os without checking apache header. If we add
apache header check in travis file(see [1]), it fails on some os.


Can we add a new pipeline which is only used to check apache header on
linux? I found that there many free continuous integration service at [2].
Shall we choose one of them?


[1]  https://github.com/apache/incubator-iotdb/pull/84
[2] https://github.com/marketplace/category/continuous-integration


Thanks
XuYi



Re: Problems about rat plugin and apache header check

Posted by yi xu <xu...@126.com>.
Just in curiosity, our rat plugin is 

<plugin>
    <groupId>org.apache.rat</groupId>
    <artifactId>apache-rat-plugin</artifactId>
    <executions>
        <execution>
            <id>license-check</id>
            <phase>verify</phase>
            <goals>
                <goal>check</goal>
            </goals>
        </execution>
    </executions>
</plugin>

According to maven grammar, if I want to execute this plugin manually, use ‘mvn rat:check’. However, I got:

[ERROR] Failed to execute goal org.codehaus.mojo:rat-maven-plugin:1.0-alpha-3:check (default-cli) on project root: Too many unapproved licenses: 88 -> [Help 1]

It seems to use another plugin from org.codehaus.mojo instead of org.apache.rat. I wonder why it occurs.

BTW, If I want to trigger the rat plugin we defined in pom.xml, I should use `apache-rat:check`.


> On Mar 4, 2019, at 00:10, Xiangdong Huang <sa...@gmail.com> wrote:
> 
> Hi,
> 
> In PR #84, I add missing Apache rat on two textual files, I will merge it
> now to let Apache Jenkins CI works.
> In this PR, I skip the apache-rat check on Win temporarily, for letting
> Travis CI works.
> 
> I also create an issue on JIRA to fix this problem eventually:
> https://issues.apache.org/jira/browse/IOTDB-33
> 
> By the way,
> 
>> I have observed the windows and non-windows version to differently detect
> binary files.
> 
> It make sense. But As YiXu reported, apache-rat check also fails on Linux
> (with OpenJDK11):
> https://github.com/apache/incubator-iotdb/pull/84#issuecomment-468993811
> 
> Best
> 
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
> 
> 黄向东
> 清华大学 软件学院
> 
> 
> Christofer Dutz <ch...@c-ware.de> 于2019年3月3日周日 下午10:38写道:
> 
>> Hi all,
>> 
>> I have observed the windows and non-windows version to differently detect
>> binary files.
>> Usually it is best not to rely on default detection of binary types (as
>> soon as the plugin detects a binary, it will not comment on it having no
>> headers)
>> 
>> Chris
>> 
>> Am 03.03.19, 15:17 schrieb "徐毅" <xu...@126.com>:
>> 
>>    It seems that `exclude` configuration does not work on windows, I run
>> "mvn rat:check" command on win10 and jdk8.
>> 
>> 
>>    Tha rat.txt outputs as follow:
>> 
>> 
>>     *****************************************************
>>     Printing headers for files without AL header...
>> 
>> 
>> 
>> 
>> 
>> =======================================================================
>>     ==.checkstyle
>> 
>> =======================================================================
>>     <?xml version="1.0" encoding="UTF-8"?>
>> 
>> 
>>    <fileset-config file-format-version="1.2.0" simple-config="true"
>> sync-formatter=
>>                                                  "false">
>>      <local-check-config name="google" location="checkstyle.xml"
>> type="project" des
>>                                                    cription="">
>>        <additional-data name="protect-config-file" value="false"/>
>>      </local-check-config>
>>      <fileset name="all" enabled="true" check-config-name="Google Checks"
>> local="fa
>>                                            lse">
>>        <file-match-pattern match-pattern="." include-pattern="true"/>
>>      </fileset>
>>    </fileset-config>
>> 
>> 
>> 
>> =======================================================================
>>     ==.git/COMMIT_EDITMSG
>> 
>> =======================================================================
>>     add debug log info for jdbc service
>> 
>> 
>> 
>> =======================================================================
>>     ==.git/config
>> 
>> =======================================================================
>>     [core]
>>            repositoryformatversion = 0
>>            filemode = false
>>            bare = false
>>            logallrefupdates = true
>>            symlinks = false
>>            ignorecase = true
>>    [remote "origin"]
>>            url = git@github.com:apache/incubator-iotdb.git
>>            fetch = +refs/heads/*:refs/remotes/origin/*
>>    [branch "master"]
>>            remote = origin
>>            merge = refs/heads/master
>>    [branch "doc"]
>>            remote = origin
>>            merge = refs/heads/doc
>>    [branch "add_iotdb_env_script_test"]
>> 
>> 
>>    On 3/3/2019 22:02,Xiangdong Huang<sa...@gmail.com> wrote:
>>    Hi,
>> 
>>    I notice that win-oraclejdk8, win-oraclejdk11 and linux-openjdk11
>> fails on
>>    https://travis-ci.org/apache/incubator-iotdb/builds/500987110
>> 
>>    It is easy that just skip apache-rat check on the above 3 jobs. But, I
>>    wonder why they failed before I skip that...
>> 
>>    Does anyone know how to print the file on Travis? Or, if someone has
>> Win OS
>>    with oracle jdk8/11, please run `mvn apache-rat:check` to verify the
>> result.
>> 
>>    [ERROR] Failed to execute goal
>>    org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project
>> root:
>>    Too many files with unapproved license: 3057 See RAT report in:
>>    C:\Users\travis\build\apache\incubator-iotdb\target\rat.txt
>> 
>>    Best,
>>    -----------------------------------
>>    Xiangdong Huang
>>    School of Software, Tsinghua University
>> 
>>    黄向东
>>    清华大学 软件学院
>> 
>> 
>>    Xiangdong Huang <sa...@gmail.com> 于2019年3月3日周日 下午9:50写道:
>> 
>>    Hi,
>> 
>>    I am not sure whether travis can provide a separated pipeline to run
>>    user-specified command.
>> 
>>    What do you mean about `user-specified command`?
>> 
>>    Best,
>> 
>>    -----------------------------------
>>    Xiangdong Huang
>>    School of Software, Tsinghua University
>> 
>>    黄向东
>>    清华大学 软件学院
>> 
>> 
>>    徐毅 <xu...@126.com> 于2019年3月3日周日 下午8:13写道:
>> 
>>    Hi
>> 
>> 
>>    When someone creates a pull request from forked repo, jenkins won't
>>    trigger to run tests. So we use travis-ci to trigger tests on
>> different os.
>>    I am not sure whether travis can provide a separated pipeline to run
>>    user-specified command.
>> 
>> 
>>    Thanks
>>    XuYi
>> 
>> 
>>    On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
>>    Hi,
>> 
>>    this behavior sounds strange.
>>    But I think this pipeline should be build into the Jenkins build, or?
>>    It should be pretty easy to force one build step to a specific os.
>> 
>>    Perhaps we should open a Jira for that issue to finally track down the
>>    real source of the problem.
>> 
>>    Julian
>> 
>>    Von meinem Mobiltelefon gesendet
>> 
>> 
>>    -------- Ursprüngliche Nachricht --------
>>    Betreff: Problems about rat plugin and apache header check
>>    Von: 徐毅
>>    An: dev@iotdb.apache.org
>>    Cc:
>> 
>>    Hi,
>> 
>> 
>>    Now we use rat plugin to check apache header, it seems that our project
>>    can pass rat check on linux but failed on windows.
>> 
>> 
>>    If someone creates a pull request from his forked repo, we use
>> travis-ci
>>    to run tests on different os without checking apache header. If we add
>>    apache header check in travis file(see [1]), it fails on some os.
>> 
>> 
>>    Can we add a new pipeline which is only used to check apache header on
>>    linux? I found that there many free continuous integration service at
>> [2].
>>    Shall we choose one of them?
>> 
>> 
>>    [1]  https://github.com/apache/incubator-iotdb/pull/84
>>    [2] https://github.com/marketplace/category/continuous-integration
>> 
>> 
>>    Thanks
>>    XuYi
>> 
>> 
>> 
>> 
>> 


Re: AW: Problems about rat plugin and apache header check

Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,

In PR #84, I add missing Apache rat on two textual files, I will merge it
now to let Apache Jenkins CI works.
In this PR, I skip the apache-rat check on Win temporarily, for letting
Travis CI works.

I also create an issue on JIRA to fix this problem eventually:
https://issues.apache.org/jira/browse/IOTDB-33

By the way,

> I have observed the windows and non-windows version to differently detect
binary files.

It make sense. But As YiXu reported, apache-rat check also fails on Linux
(with OpenJDK11):
https://github.com/apache/incubator-iotdb/pull/84#issuecomment-468993811

Best

-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Christofer Dutz <ch...@c-ware.de> 于2019年3月3日周日 下午10:38写道:

> Hi all,
>
> I have observed the windows and non-windows version to differently detect
> binary files.
> Usually it is best not to rely on default detection of binary types (as
> soon as the plugin detects a binary, it will not comment on it having no
> headers)
>
> Chris
>
> Am 03.03.19, 15:17 schrieb "徐毅" <xu...@126.com>:
>
>     It seems that `exclude` configuration does not work on windows, I run
> "mvn rat:check" command on win10 and jdk8.
>
>
>     Tha rat.txt outputs as follow:
>
>
>      *****************************************************
>      Printing headers for files without AL header...
>
>
>
>
>
>  =======================================================================
>      ==.checkstyle
>
>  =======================================================================
>      <?xml version="1.0" encoding="UTF-8"?>
>
>
>     <fileset-config file-format-version="1.2.0" simple-config="true"
> sync-formatter=
>                                                   "false">
>       <local-check-config name="google" location="checkstyle.xml"
> type="project" des
>                                                     cription="">
>         <additional-data name="protect-config-file" value="false"/>
>       </local-check-config>
>       <fileset name="all" enabled="true" check-config-name="Google Checks"
> local="fa
>                                             lse">
>         <file-match-pattern match-pattern="." include-pattern="true"/>
>       </fileset>
>     </fileset-config>
>
>
>
>  =======================================================================
>      ==.git/COMMIT_EDITMSG
>
>  =======================================================================
>      add debug log info for jdbc service
>
>
>
>  =======================================================================
>      ==.git/config
>
>  =======================================================================
>      [core]
>             repositoryformatversion = 0
>             filemode = false
>             bare = false
>             logallrefupdates = true
>             symlinks = false
>             ignorecase = true
>     [remote "origin"]
>             url = git@github.com:apache/incubator-iotdb.git
>             fetch = +refs/heads/*:refs/remotes/origin/*
>     [branch "master"]
>             remote = origin
>             merge = refs/heads/master
>     [branch "doc"]
>             remote = origin
>             merge = refs/heads/doc
>     [branch "add_iotdb_env_script_test"]
>
>
>     On 3/3/2019 22:02,Xiangdong Huang<sa...@gmail.com> wrote:
>     Hi,
>
>     I notice that win-oraclejdk8, win-oraclejdk11 and linux-openjdk11
> fails on
>     https://travis-ci.org/apache/incubator-iotdb/builds/500987110
>
>     It is easy that just skip apache-rat check on the above 3 jobs. But, I
>     wonder why they failed before I skip that...
>
>     Does anyone know how to print the file on Travis? Or, if someone has
> Win OS
>     with oracle jdk8/11, please run `mvn apache-rat:check` to verify the
> result.
>
>     [ERROR] Failed to execute goal
>     org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project
> root:
>     Too many files with unapproved license: 3057 See RAT report in:
>     C:\Users\travis\build\apache\incubator-iotdb\target\rat.txt
>
>     Best,
>     -----------------------------------
>     Xiangdong Huang
>     School of Software, Tsinghua University
>
>     黄向东
>     清华大学 软件学院
>
>
>     Xiangdong Huang <sa...@gmail.com> 于2019年3月3日周日 下午9:50写道:
>
>     Hi,
>
>     I am not sure whether travis can provide a separated pipeline to run
>     user-specified command.
>
>     What do you mean about `user-specified command`?
>
>     Best,
>
>     -----------------------------------
>     Xiangdong Huang
>     School of Software, Tsinghua University
>
>     黄向东
>     清华大学 软件学院
>
>
>     徐毅 <xu...@126.com> 于2019年3月3日周日 下午8:13写道:
>
>     Hi
>
>
>     When someone creates a pull request from forked repo, jenkins won't
>     trigger to run tests. So we use travis-ci to trigger tests on
> different os.
>     I am not sure whether travis can provide a separated pipeline to run
>     user-specified command.
>
>
>     Thanks
>     XuYi
>
>
>     On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
>     Hi,
>
>     this behavior sounds strange.
>     But I think this pipeline should be build into the Jenkins build, or?
>     It should be pretty easy to force one build step to a specific os.
>
>     Perhaps we should open a Jira for that issue to finally track down the
>     real source of the problem.
>
>     Julian
>
>     Von meinem Mobiltelefon gesendet
>
>
>     -------- Ursprüngliche Nachricht --------
>     Betreff: Problems about rat plugin and apache header check
>     Von: 徐毅
>     An: dev@iotdb.apache.org
>     Cc:
>
>     Hi,
>
>
>     Now we use rat plugin to check apache header, it seems that our project
>     can pass rat check on linux but failed on windows.
>
>
>     If someone creates a pull request from his forked repo, we use
> travis-ci
>     to run tests on different os without checking apache header. If we add
>     apache header check in travis file(see [1]), it fails on some os.
>
>
>     Can we add a new pipeline which is only used to check apache header on
>     linux? I found that there many free continuous integration service at
> [2].
>     Shall we choose one of them?
>
>
>     [1]  https://github.com/apache/incubator-iotdb/pull/84
>     [2] https://github.com/marketplace/category/continuous-integration
>
>
>     Thanks
>     XuYi
>
>
>
>
>

Re: AW: Problems about rat plugin and apache header check

Posted by Christofer Dutz <ch...@c-ware.de>.
Hi all,

I have observed the windows and non-windows version to differently detect binary files.
Usually it is best not to rely on default detection of binary types (as soon as the plugin detects a binary, it will not comment on it having no headers)

Chris

Am 03.03.19, 15:17 schrieb "徐毅" <xu...@126.com>:

    It seems that `exclude` configuration does not work on windows, I run "mvn rat:check" command on win10 and jdk8.
    
    
    Tha rat.txt outputs as follow:
    
    
     *****************************************************
     Printing headers for files without AL header...
    
    
    
    
     =======================================================================
     ==.checkstyle
     =======================================================================
     <?xml version="1.0" encoding="UTF-8"?>
    
    
    <fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter=                                                                                                              "false">
      <local-check-config name="google" location="checkstyle.xml" type="project" des                                                                                                              cription="">
        <additional-data name="protect-config-file" value="false"/>
      </local-check-config>
      <fileset name="all" enabled="true" check-config-name="Google Checks" local="fa                                                                                                              lse">
        <file-match-pattern match-pattern="." include-pattern="true"/>
      </fileset>
    </fileset-config>
    
    
     =======================================================================
     ==.git/COMMIT_EDITMSG
     =======================================================================
     add debug log info for jdbc service
    
    
     =======================================================================
     ==.git/config
     =======================================================================
     [core]
            repositoryformatversion = 0
            filemode = false
            bare = false
            logallrefupdates = true
            symlinks = false
            ignorecase = true
    [remote "origin"]
            url = git@github.com:apache/incubator-iotdb.git
            fetch = +refs/heads/*:refs/remotes/origin/*
    [branch "master"]
            remote = origin
            merge = refs/heads/master
    [branch "doc"]
            remote = origin
            merge = refs/heads/doc
    [branch "add_iotdb_env_script_test"]
    
    
    On 3/3/2019 22:02,Xiangdong Huang<sa...@gmail.com> wrote:
    Hi,
    
    I notice that win-oraclejdk8, win-oraclejdk11 and linux-openjdk11 fails on
    https://travis-ci.org/apache/incubator-iotdb/builds/500987110
    
    It is easy that just skip apache-rat check on the above 3 jobs. But, I
    wonder why they failed before I skip that...
    
    Does anyone know how to print the file on Travis? Or, if someone has Win OS
    with oracle jdk8/11, please run `mvn apache-rat:check` to verify the result.
    
    [ERROR] Failed to execute goal
    org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project root:
    Too many files with unapproved license: 3057 See RAT report in:
    C:\Users\travis\build\apache\incubator-iotdb\target\rat.txt
    
    Best,
    -----------------------------------
    Xiangdong Huang
    School of Software, Tsinghua University
    
    黄向东
    清华大学 软件学院
    
    
    Xiangdong Huang <sa...@gmail.com> 于2019年3月3日周日 下午9:50写道:
    
    Hi,
    
    I am not sure whether travis can provide a separated pipeline to run
    user-specified command.
    
    What do you mean about `user-specified command`?
    
    Best,
    
    -----------------------------------
    Xiangdong Huang
    School of Software, Tsinghua University
    
    黄向东
    清华大学 软件学院
    
    
    徐毅 <xu...@126.com> 于2019年3月3日周日 下午8:13写道:
    
    Hi
    
    
    When someone creates a pull request from forked repo, jenkins won't
    trigger to run tests. So we use travis-ci to trigger tests on different os.
    I am not sure whether travis can provide a separated pipeline to run
    user-specified command.
    
    
    Thanks
    XuYi
    
    
    On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
    Hi,
    
    this behavior sounds strange.
    But I think this pipeline should be build into the Jenkins build, or?
    It should be pretty easy to force one build step to a specific os.
    
    Perhaps we should open a Jira for that issue to finally track down the
    real source of the problem.
    
    Julian
    
    Von meinem Mobiltelefon gesendet
    
    
    -------- Ursprüngliche Nachricht --------
    Betreff: Problems about rat plugin and apache header check
    Von: 徐毅
    An: dev@iotdb.apache.org
    Cc:
    
    Hi,
    
    
    Now we use rat plugin to check apache header, it seems that our project
    can pass rat check on linux but failed on windows.
    
    
    If someone creates a pull request from his forked repo, we use travis-ci
    to run tests on different os without checking apache header. If we add
    apache header check in travis file(see [1]), it fails on some os.
    
    
    Can we add a new pipeline which is only used to check apache header on
    linux? I found that there many free continuous integration service at [2].
    Shall we choose one of them?
    
    
    [1]  https://github.com/apache/incubator-iotdb/pull/84
    [2] https://github.com/marketplace/category/continuous-integration
    
    
    Thanks
    XuYi
    
    
    


Re: AW: Problems about rat plugin and apache header check

Posted by 徐毅 <xu...@126.com>.
It seems that `exclude` configuration does not work on windows, I run "mvn rat:check" command on win10 and jdk8.


Tha rat.txt outputs as follow:


 *****************************************************
 Printing headers for files without AL header...




 =======================================================================
 ==.checkstyle
 =======================================================================
 <?xml version="1.0" encoding="UTF-8"?>


<fileset-config file-format-version="1.2.0" simple-config="true" sync-formatter=                                                                                                              "false">
  <local-check-config name="google" location="checkstyle.xml" type="project" des                                                                                                              cription="">
    <additional-data name="protect-config-file" value="false"/>
  </local-check-config>
  <fileset name="all" enabled="true" check-config-name="Google Checks" local="fa                                                                                                              lse">
    <file-match-pattern match-pattern="." include-pattern="true"/>
  </fileset>
</fileset-config>


 =======================================================================
 ==.git/COMMIT_EDITMSG
 =======================================================================
 add debug log info for jdbc service


 =======================================================================
 ==.git/config
 =======================================================================
 [core]
        repositoryformatversion = 0
        filemode = false
        bare = false
        logallrefupdates = true
        symlinks = false
        ignorecase = true
[remote "origin"]
        url = git@github.com:apache/incubator-iotdb.git
        fetch = +refs/heads/*:refs/remotes/origin/*
[branch "master"]
        remote = origin
        merge = refs/heads/master
[branch "doc"]
        remote = origin
        merge = refs/heads/doc
[branch "add_iotdb_env_script_test"]


On 3/3/2019 22:02,Xiangdong Huang<sa...@gmail.com> wrote:
Hi,

I notice that win-oraclejdk8, win-oraclejdk11 and linux-openjdk11 fails on
https://travis-ci.org/apache/incubator-iotdb/builds/500987110

It is easy that just skip apache-rat check on the above 3 jobs. But, I
wonder why they failed before I skip that...

Does anyone know how to print the file on Travis? Or, if someone has Win OS
with oracle jdk8/11, please run `mvn apache-rat:check` to verify the result.

[ERROR] Failed to execute goal
org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project root:
Too many files with unapproved license: 3057 See RAT report in:
C:\Users\travis\build\apache\incubator-iotdb\target\rat.txt

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

黄向东
清华大学 软件学院


Xiangdong Huang <sa...@gmail.com> 于2019年3月3日周日 下午9:50写道:

Hi,

I am not sure whether travis can provide a separated pipeline to run
user-specified command.

What do you mean about `user-specified command`?

Best,

-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

黄向东
清华大学 软件学院


徐毅 <xu...@126.com> 于2019年3月3日周日 下午8:13写道:

Hi


When someone creates a pull request from forked repo, jenkins won't
trigger to run tests. So we use travis-ci to trigger tests on different os.
I am not sure whether travis can provide a separated pipeline to run
user-specified command.


Thanks
XuYi


On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
Hi,

this behavior sounds strange.
But I think this pipeline should be build into the Jenkins build, or?
It should be pretty easy to force one build step to a specific os.

Perhaps we should open a Jira for that issue to finally track down the
real source of the problem.

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Betreff: Problems about rat plugin and apache header check
Von: 徐毅
An: dev@iotdb.apache.org
Cc:

Hi,


Now we use rat plugin to check apache header, it seems that our project
can pass rat check on linux but failed on windows.


If someone creates a pull request from his forked repo, we use travis-ci
to run tests on different os without checking apache header. If we add
apache header check in travis file(see [1]), it fails on some os.


Can we add a new pipeline which is only used to check apache header on
linux? I found that there many free continuous integration service at [2].
Shall we choose one of them?


[1]  https://github.com/apache/incubator-iotdb/pull/84
[2] https://github.com/marketplace/category/continuous-integration


Thanks
XuYi



Re: AW: Problems about rat plugin and apache header check

Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,

I notice that win-oraclejdk8, win-oraclejdk11 and linux-openjdk11 fails on
https://travis-ci.org/apache/incubator-iotdb/builds/500987110

It is easy that just skip apache-rat check on the above 3 jobs. But, I
wonder why they failed before I skip that...

Does anyone know how to print the file on Travis? Or, if someone has Win OS
with oracle jdk8/11, please run `mvn apache-rat:check` to verify the result.

> [ERROR] Failed to execute goal
org.apache.rat:apache-rat-plugin:0.12:check (default-cli) on project root:
Too many files with unapproved license: 3057 See RAT report in:
C:\Users\travis\build\apache\incubator-iotdb\target\rat.txt

Best,
-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


Xiangdong Huang <sa...@gmail.com> 于2019年3月3日周日 下午9:50写道:

> Hi,
>
> > I am not sure whether travis can provide a separated pipeline to run
> user-specified command.
>
> What do you mean about `user-specified command`?
>
> Best,
>
> -----------------------------------
> Xiangdong Huang
> School of Software, Tsinghua University
>
>  黄向东
> 清华大学 软件学院
>
>
> 徐毅 <xu...@126.com> 于2019年3月3日周日 下午8:13写道:
>
>> Hi
>>
>>
>> When someone creates a pull request from forked repo, jenkins won't
>> trigger to run tests. So we use travis-ci to trigger tests on different os.
>> I am not sure whether travis can provide a separated pipeline to run
>> user-specified command.
>>
>>
>> Thanks
>> XuYi
>>
>>
>> On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
>> Hi,
>>
>> this behavior sounds strange.
>> But I think this pipeline should be build into the Jenkins build, or?
>> It should be pretty easy to force one build step to a specific os.
>>
>> Perhaps we should open a Jira for that issue to finally track down the
>> real source of the problem.
>>
>> Julian
>>
>> Von meinem Mobiltelefon gesendet
>>
>>
>> -------- Ursprüngliche Nachricht --------
>> Betreff: Problems about rat plugin and apache header check
>> Von: 徐毅
>> An: dev@iotdb.apache.org
>> Cc:
>>
>> Hi,
>>
>>
>> Now we use rat plugin to check apache header, it seems that our project
>> can pass rat check on linux but failed on windows.
>>
>>
>> If someone creates a pull request from his forked repo, we use travis-ci
>> to run tests on different os without checking apache header. If we add
>> apache header check in travis file(see [1]), it fails on some os.
>>
>>
>> Can we add a new pipeline which is only used to check apache header on
>> linux? I found that there many free continuous integration service at [2].
>> Shall we choose one of them?
>>
>>
>> [1]  https://github.com/apache/incubator-iotdb/pull/84
>> [2] https://github.com/marketplace/category/continuous-integration
>>
>>
>> Thanks
>> XuYi
>>
>>

Re: AW: Problems about rat plugin and apache header check

Posted by Xiangdong Huang <sa...@gmail.com>.
Hi,

> I am not sure whether travis can provide a separated pipeline to run
user-specified command.

What do you mean about `user-specified command`?

Best,

-----------------------------------
Xiangdong Huang
School of Software, Tsinghua University

 黄向东
清华大学 软件学院


徐毅 <xu...@126.com> 于2019年3月3日周日 下午8:13写道:

> Hi
>
>
> When someone creates a pull request from forked repo, jenkins won't
> trigger to run tests. So we use travis-ci to trigger tests on different os.
> I am not sure whether travis can provide a separated pipeline to run
> user-specified command.
>
>
> Thanks
> XuYi
>
>
> On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
> Hi,
>
> this behavior sounds strange.
> But I think this pipeline should be build into the Jenkins build, or?
> It should be pretty easy to force one build step to a specific os.
>
> Perhaps we should open a Jira for that issue to finally track down the
> real source of the problem.
>
> Julian
>
> Von meinem Mobiltelefon gesendet
>
>
> -------- Ursprüngliche Nachricht --------
> Betreff: Problems about rat plugin and apache header check
> Von: 徐毅
> An: dev@iotdb.apache.org
> Cc:
>
> Hi,
>
>
> Now we use rat plugin to check apache header, it seems that our project
> can pass rat check on linux but failed on windows.
>
>
> If someone creates a pull request from his forked repo, we use travis-ci
> to run tests on different os without checking apache header. If we add
> apache header check in travis file(see [1]), it fails on some os.
>
>
> Can we add a new pipeline which is only used to check apache header on
> linux? I found that there many free continuous integration service at [2].
> Shall we choose one of them?
>
>
> [1]  https://github.com/apache/incubator-iotdb/pull/84
> [2] https://github.com/marketplace/category/continuous-integration
>
>
> Thanks
> XuYi
>
>

Re: AW: Problems about rat plugin and apache header check

Posted by 徐毅 <xu...@126.com>.
Hi


When someone creates a pull request from forked repo, jenkins won't trigger to run tests. So we use travis-ci to trigger tests on different os. I am not sure whether travis can provide a separated pipeline to run user-specified command.


Thanks
XuYi


On 3/3/2019 19:46,Julian Feinauer<j....@pragmaticminds.de> wrote:
Hi,

this behavior sounds strange.
But I think this pipeline should be build into the Jenkins build, or?
It should be pretty easy to force one build step to a specific os.

Perhaps we should open a Jira for that issue to finally track down the real source of the problem.

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Betreff: Problems about rat plugin and apache header check
Von: 徐毅
An: dev@iotdb.apache.org
Cc:

Hi,


Now we use rat plugin to check apache header, it seems that our project can pass rat check on linux but failed on windows.


If someone creates a pull request from his forked repo, we use travis-ci to run tests on different os without checking apache header. If we add apache header check in travis file(see [1]), it fails on some os.


Can we add a new pipeline which is only used to check apache header on linux? I found that there many free continuous integration service at [2]. Shall we choose one of them?


[1]  https://github.com/apache/incubator-iotdb/pull/84
[2] https://github.com/marketplace/category/continuous-integration


Thanks
XuYi


AW: Problems about rat plugin and apache header check

Posted by Julian Feinauer <j....@pragmaticminds.de>.
Hi,

this behavior sounds strange.
But I think this pipeline should be build into the Jenkins build, or?
It should be pretty easy to force one build step to a specific os.

Perhaps we should open a Jira for that issue to finally track down the real source of the problem.

Julian

Von meinem Mobiltelefon gesendet


-------- Ursprüngliche Nachricht --------
Betreff: Problems about rat plugin and apache header check
Von: 徐毅
An: dev@iotdb.apache.org
Cc:

Hi,


Now we use rat plugin to check apache header, it seems that our project can pass rat check on linux but failed on windows.


If someone creates a pull request from his forked repo, we use travis-ci to run tests on different os without checking apache header. If we add apache header check in travis file(see [1]), it fails on some os.


Can we add a new pipeline which is only used to check apache header on linux? I found that there many free continuous integration service at [2]. Shall we choose one of them?


[1]  https://github.com/apache/incubator-iotdb/pull/84
[2] https://github.com/marketplace/category/continuous-integration


Thanks
XuYi