You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by GitBox <gi...@apache.org> on 2020/02/10 23:45:21 UTC
[GitHub] [storm] bipinprasad opened a new pull request #3207: [STORM-3580]
Processs -c option to storm.py for Rebalance
bipinprasad opened a new pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm commented on a change in pull request #3207:
[STORM-3580] Processs -c option to storm.py for Rebalance
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207#discussion_r378389660
##########
File path: storm-core/src/jvm/org/apache/storm/command/Rebalance.java
##########
@@ -57,6 +58,15 @@ public static void main(String[] args) throws Exception {
}
Map<String, Object> confOverrides = (Map<String, Object>) cl.get("t");
+ Map<String, Object> jvmOpts = Utils.readCommandLineOpts(); // values in -Dstorm.options (originally -c in storm.py)
Review comment:
This is mostly a question: Do we want to include default `storm.yaml` into this too?
for example:
https://github.com/apache/storm/blob/master/storm-core/src/jvm/org/apache/storm/command/ShellSubmission.java#L35
this reads `storm.yaml` and commandLineOpts
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm commented on a change in pull request #3207:
[STORM-3580] Processs -c option to storm.py for Rebalance
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207#discussion_r378553815
##########
File path: storm-core/src/jvm/org/apache/storm/command/Rebalance.java
##########
@@ -57,6 +58,15 @@ public static void main(String[] args) throws Exception {
}
Map<String, Object> confOverrides = (Map<String, Object>) cl.get("t");
+ Map<String, Object> jvmOpts = Utils.readCommandLineOpts(); // values in -Dstorm.options (originally -c in storm.py)
Review comment:
Offline discussion with Bipin :
> I don’t think we want that - that would be a reset+. Since rebalance should an incremental change to the currently running Topo.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm commented on a change in pull request #3207:
[STORM-3580] Processs -c option to storm.py for Rebalance
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207#discussion_r378394295
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3356,6 +3356,12 @@ public void rebalance(String topoName, RebalanceOptions options)
if (subject != null) {
options.set_principal(subject.getPrincipals().iterator().next().getName());
}
+ String topoId = toTopoId(topoName);
Review comment:
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm merged pull request #3207: [STORM-3580] Processs -c
option to storm.py for Rebalance
Posted by GitBox <gi...@apache.org>.
Ethanlm merged pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] bipinprasad commented on a change in pull request #3207:
[STORM-3580] Processs -c option to storm.py for Rebalance
Posted by GitBox <gi...@apache.org>.
bipinprasad commented on a change in pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207#discussion_r378283922
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3356,6 +3356,12 @@ public void rebalance(String topoName, RebalanceOptions options)
if (subject != null) {
options.set_principal(subject.getPrincipals().iterator().next().getName());
}
+ String topoId = toTopoId(topoName);
Review comment:
Reverted Nimbus.java rebalance() changes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] bipinprasad commented on a change in pull request #3207:
[STORM-3580] Processs -c option to storm.py for Rebalance
Posted by GitBox <gi...@apache.org>.
bipinprasad commented on a change in pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207#discussion_r378205413
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3356,6 +3356,12 @@ public void rebalance(String topoName, RebalanceOptions options)
if (subject != null) {
options.set_principal(subject.getPrincipals().iterator().next().getName());
}
+ String topoId = toTopoId(topoName);
Review comment:
Rebalance will not work without the change below. Should the change to Nimus.java be part of a different Jira then?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [storm] Ethanlm commented on a change in pull request #3207:
[STORM-3580] Processs -c option to storm.py for Rebalance
Posted by GitBox <gi...@apache.org>.
Ethanlm commented on a change in pull request #3207: [STORM-3580] Processs -c option to storm.py for Rebalance
URL: https://github.com/apache/storm/pull/3207#discussion_r378015388
##########
File path: storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java
##########
@@ -3356,6 +3356,12 @@ public void rebalance(String topoName, RebalanceOptions options)
if (subject != null) {
options.set_principal(subject.getPrincipals().iterator().next().getName());
}
+ String topoId = toTopoId(topoName);
Review comment:
I think the change here should not be part of this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services