You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Jaimin Jetly <ja...@hortonworks.com> on 2017/01/06 01:21:47 UTC
Review Request 55245: ambari-web action to download all client
configs of a service
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55245/
-----------------------------------------------------------
Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
Bugs: AMBARI-19394
https://issues.apache.org/jira/browse/AMBARI-19394
Repository: ambari
Description
-------
Add a new ambari-web action to download all client configs of a service. This action should be added in the submenu for "Download Client Conifgs" labelled item in the service action
Diffs
-----
ambari-web/app/controllers/main/service/item.js be3fac1
ambari-web/app/messages.js 3642e5a
ambari-web/test/controllers/main/service/item_test.js 78ed0a6
Diff: https://reviews.apache.org/r/55245/diff/
Testing
-------
verified that patch works as expected on a cluster.
verified that all ambari-web unit tests passes with the patch:
20121 passing (16s)
153 pending
Thanks,
Jaimin Jetly
Re: Review Request 55245: ambari-web action to download all client
configs of a service
Posted by Yusaku Sako <yu...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55245/#review160663
-----------------------------------------------------------
Ship it!
Ship It!
- Yusaku Sako
On Jan. 6, 2017, 1:21 a.m., Jaimin Jetly wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55245/
> -----------------------------------------------------------
>
> (Updated Jan. 6, 2017, 1:21 a.m.)
>
>
> Review request for Ambari, Richard Zang, Xi Wang, and Yusaku Sako.
>
>
> Bugs: AMBARI-19394
> https://issues.apache.org/jira/browse/AMBARI-19394
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Add a new ambari-web action to download all client configs of a service. This action should be added in the submenu for "Download Client Conifgs" labelled item in the service action
>
>
> Diffs
> -----
>
> ambari-web/app/controllers/main/service/item.js be3fac1
> ambari-web/app/messages.js 3642e5a
> ambari-web/test/controllers/main/service/item_test.js 78ed0a6
>
> Diff: https://reviews.apache.org/r/55245/diff/
>
>
> Testing
> -------
>
> verified that patch works as expected on a cluster.
> verified that all ambari-web unit tests passes with the patch:
> 20121 passing (16s)
> 153 pending
>
>
> Thanks,
>
> Jaimin Jetly
>
>