You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/09/19 16:03:58 UTC
[GitHub] [iceberg] amogh-jahagirdar commented on a diff in pull request #5792: API,Core: Add scan planning metrics for scanned/skipped delete manifests
amogh-jahagirdar commented on code in PR #5792:
URL: https://github.com/apache/iceberg/pull/5792#discussion_r974423954
##########
core/src/test/java/org/apache/iceberg/TestScanPlanningAndReporting.java:
##########
@@ -123,11 +129,86 @@ public void scanningWithDeletes() throws IOException {
assertThat(scanReport.scanMetrics().resultDataFiles().value()).isEqualTo(3);
assertThat(scanReport.scanMetrics().resultDeleteFiles().value()).isEqualTo(2);
assertThat(scanReport.scanMetrics().scannedDataManifests().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().scannedDeleteManifests().value()).isEqualTo(1);
assertThat(scanReport.scanMetrics().skippedDataManifests().value()).isEqualTo(0);
+ assertThat(scanReport.scanMetrics().skippedDeleteManifests().value()).isEqualTo(0);
assertThat(scanReport.scanMetrics().totalDataManifests().value()).isEqualTo(1);
assertThat(scanReport.scanMetrics().totalDeleteManifests().value()).isEqualTo(1);
assertThat(scanReport.scanMetrics().totalFileSizeInBytes().value()).isEqualTo(30L);
assertThat(scanReport.scanMetrics().totalDeleteFileSizeInBytes().value()).isEqualTo(20L);
+ assertThat(scanReport.scanMetrics().skippedDataFiles().value()).isEqualTo(0);
+ assertThat(scanReport.scanMetrics().skippedDeleteFiles().value()).isEqualTo(0);
+ }
+
+ @Test
+ public void scanningWithSkippedDataFiles() throws IOException {
+ String tableName = "scan-planning-with-skipped-data-files";
+ Table table =
+ TestTables.create(
+ tableDir, tableName, SCHEMA, SPEC, SortOrder.unsorted(), formatVersion, reporter);
+ table.newAppend().appendFile(FILE_A).appendFile(FILE_D).commit();
+ table.newAppend().appendFile(FILE_B).appendFile(FILE_C).commit();
+ TableScan tableScan = table.newScan();
+
+ try (CloseableIterable<FileScanTask> fileScanTasks =
+ tableScan.filter(Expressions.equal("data", "1")).planFiles()) {
+ fileScanTasks.forEach(task -> {});
+ }
+
+ ScanReport scanReport = reporter.lastReport();
+ assertThat(scanReport).isNotNull();
+ assertThat(scanReport.tableName()).isEqualTo(tableName);
+ assertThat(scanReport.snapshotId()).isEqualTo(2L);
+ assertThat(scanReport.scanMetrics().skippedDataFiles().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().skippedDeleteFiles().value()).isEqualTo(0);
+ assertThat(scanReport.scanMetrics().totalPlanningDuration().totalDuration())
+ .isGreaterThan(Duration.ZERO);
+ assertThat(scanReport.scanMetrics().resultDataFiles().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().resultDeleteFiles().value()).isEqualTo(0);
+ assertThat(scanReport.scanMetrics().scannedDataManifests().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().scannedDeleteManifests().value()).isEqualTo(0);
+ assertThat(scanReport.scanMetrics().skippedDataManifests().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().skippedDeleteManifests().value()).isEqualTo(0);
+ assertThat(scanReport.scanMetrics().totalDataManifests().value()).isEqualTo(2);
+ assertThat(scanReport.scanMetrics().totalDeleteManifests().value()).isEqualTo(0);
+ assertThat(scanReport.scanMetrics().totalFileSizeInBytes().value()).isEqualTo(10L);
+ assertThat(scanReport.scanMetrics().totalDeleteFileSizeInBytes().value()).isEqualTo(0L);
+ }
+
+ @Test
+ public void scanningWithSkippedDeleteFiles() throws IOException {
+ String tableName = "scan-planning-with-skipped-delete-files";
+ Table table =
+ TestTables.create(
+ tableDir, tableName, SCHEMA, SPEC, SortOrder.unsorted(), formatVersion, reporter);
+ table.newAppend().appendFile(FILE_A).appendFile(FILE_D).commit();
+ table.newRowDelta().addDeletes(FILE_A_DELETES).addDeletes(FILE_D2_DELETES).commit();
+ table.newRowDelta().addDeletes(FILE_B_DELETES).addDeletes(FILE_C2_DELETES).commit();
+ TableScan tableScan = table.newScan();
+
+ try (CloseableIterable<FileScanTask> fileScanTasks =
+ tableScan.filter(Expressions.equal("data", "1")).planFiles()) {
+ fileScanTasks.forEach(task -> {});
+ }
+
+ ScanReport scanReport = reporter.lastReport();
+ assertThat(scanReport).isNotNull();
+ assertThat(scanReport.tableName()).isEqualTo(tableName);
+ assertThat(scanReport.snapshotId()).isEqualTo(3L);
+ assertThat(scanReport.scanMetrics().totalPlanningDuration().totalDuration())
+ .isGreaterThan(Duration.ZERO);
+ assertThat(scanReport.scanMetrics().resultDataFiles().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().resultDeleteFiles().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().skippedDataFiles().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().skippedDeleteFiles().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().scannedDataManifests().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().scannedDeleteManifests().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().skippedDataManifests().value()).isEqualTo(0);
+ assertThat(scanReport.scanMetrics().skippedDeleteManifests().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().totalDataManifests().value()).isEqualTo(1);
+ assertThat(scanReport.scanMetrics().totalDeleteManifests().value()).isEqualTo(2);
+ assertThat(scanReport.scanMetrics().totalFileSizeInBytes().value()).isEqualTo(10L);
+ assertThat(scanReport.scanMetrics().totalDeleteFileSizeInBytes().value()).isEqualTo(10L);
Review Comment:
Nit: IMO feels more readable if scanReport.scanMetrics() is a separate variable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org