You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Christine Poerschke (JIRA)" <ji...@apache.org> on 2019/06/25 11:16:00 UTC
[jira] [Commented] (SOLR-13576) factor out a
TopGroupsShardResponseProcessor.fillResultIds method
[ https://issues.apache.org/jira/browse/SOLR-13576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16872272#comment-16872272 ]
Christine Poerschke commented on SOLR-13576:
--------------------------------------------
In the context of SOLR-11831 the method (if it has package visibility) would also help avoid code duplication:
* https://github.com/apache/lucene-solr/pull/300#discussion_r276714459
* https://github.com/cpoerschke/lucene-solr/commit/1570f7c0ad0194681897403613e87cfad367d577
* https://github.com/apache/lucene-solr/pull/300#discussion_r290346022
* https://github.com/apache/lucene-solr/commit/a7df0c0d8d9c292998df1e12848735eaa662ff38
> factor out a TopGroupsShardResponseProcessor.fillResultIds method
> -----------------------------------------------------------------
>
> Key: SOLR-13576
> URL: https://issues.apache.org/jira/browse/SOLR-13576
> Project: Solr
> Issue Type: Task
> Reporter: Christine Poerschke
> Assignee: Christine Poerschke
> Priority: Minor
>
> The {{TopGroupsShardResponseProcessor.process}} method e.g. [#L54-L215|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.1.1/solr/core/src/java/org/apache/solr/search/grouping/distributed/responseprocessor/TopGroupsShardResponseProcessor.java#L54-L215] does quite a few things and factoring out a {{fillResultIds}} (or similarly named) method for the logically distinct [#L192-L214|https://github.com/apache/lucene-solr/blob/releases/lucene-solr/8.1.1/solr/core/src/java/org/apache/solr/search/grouping/distributed/responseprocessor/TopGroupsShardResponseProcessor.java#L192-L214] portion could help with code comprehension.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org