You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/08/28 02:09:36 UTC

[GitHub] [kafka] jsancio commented on pull request #12565: KAFKA-14183; Cluster metadata bootstrap file should use header/footer

jsancio commented on PR #12565:
URL: https://github.com/apache/kafka/pull/12565#issuecomment-1229357539

   > @jsancio thanks for the patch! A few minor non-blocking comments inline. I filed a follow-up to add unit tests for BatchFileWrite since I realize I never included any (not needed for this PR). https://issues.apache.org/jira/browse/KAFKA-14186
   
   @mumrah, Yes, we could use more tests for this type. I added BatchFileWriterReaderTest in this commit to test basic header and footer support.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org