You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/04/05 20:57:11 UTC
[GitHub] [incubator-netbeans] bondolo commented on issue #173: [NETBEANS-97]
Don't add braces around try/synchronized blocks when reformatting
bondolo commented on issue #173: [NETBEANS-97] Don't add braces around try/synchronized blocks when reformatting
URL: https://github.com/apache/incubator-netbeans/pull/173#issuecomment-480419582
I looked for examples of existing Reformatter tests and could not find any. I don't believe that there are any unless I am missing something.
I would also like to understand the perceived necessity of providing an option for this change. Since the net result is for the reformatter to make fewer changes to the source the user typed I am resistant. In part because I expect that non-uniform use of the option across teams will result in the undesired braces slowly creeping in to source-bases as multiple users apply reformatting.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists