You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@camel.apache.org by "Claus Ibsen (JIRA)" <ji...@apache.org> on 2013/12/20 18:42:19 UTC

[jira] [Resolved] (CAMEL-7088) Veracode compliance. Improper Resource Shutdown or Release (CWE ID 404) in FileLockExclusiveReadLockStrategy

     [ https://issues.apache.org/jira/browse/CAMEL-7088?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Claus Ibsen resolved CAMEL-7088.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 2.11.3

I am using IOHelper.close to close them like the others.

Thanks for reporting and the patch.

> Veracode compliance. Improper Resource Shutdown or Release (CWE ID 404) in FileLockExclusiveReadLockStrategy
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: CAMEL-7088
>                 URL: https://issues.apache.org/jira/browse/CAMEL-7088
>             Project: Camel
>          Issue Type: Improvement
>          Components: camel-core
>    Affects Versions: 2.11.3, 2.12.3, 2.13.0
>            Reporter: Leonid Marushevskiy
>            Assignee: Claus Ibsen
>            Priority: Minor
>              Labels: Security, Veracode
>             Fix For: 2.11.3, 2.12.3, 2.13.0
>
>
> Pull request https://github.com/apache/camel/pull/74
> During Veracode scan of our application we discover issue with security in Camel. Please review our fix and apply it in future versions.
> Quote from Veracode report below:
> Improper Resource Shutdown or Release (CWE ID 404)(1 flaw)
> Description
> The application fails to release (or incorrectly releases) a system resource before it is made available for re-use. This
> condition often occurs with resources such as database connections or file handles. Most unreleased resource issues
> result in general software reliability problems, but if an attacker can intentionally trigger a resource leak, it may be
> possible to launch a denial of service attack by depleting the resource pool.
> Effort to Fix: 2 - Implementation error. Fix is approx. 6-50 lines of code. 1 day to fix.
> Recommendations
> When a resource is created or allocated, the developer is responsible for properly releasing the resource as well as
> accounting for all potential paths of expiration or invalidation. Ensure that all code paths properly release resources.
> Instances found via Static Scan
> .../FileLockExclusiveReadLockStrategy.java line 68



--
This message was sent by Atlassian JIRA
(v6.1.4#6159)