You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/08/15 22:55:08 UTC

[GitHub] [incubator-superset] etr2460 commented on a change in pull request #8054: [sql lab] persist tables list in localStorage

etr2460 commented on a change in pull request #8054: [sql lab] persist tables list in localStorage
URL: https://github.com/apache/incubator-superset/pull/8054#discussion_r314529851
 
 

 ##########
 File path: superset/assets/src/SqlLab/utils/reduxStateToLocalStorageHelper.js
 ##########
 @@ -21,9 +21,11 @@ import { LOCALSTORAGE_MAX_QUERY_AGE_MS } from '../constants';
 const PERSISTENT_QUERY_EDITOR_KEYS = new Set([
   'autorun',
   'dbId',
+  'height',
 
 Review comment:
   what does height mean here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org