You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/10/31 09:26:07 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request #13371: Support create scaling job from sharding rule that includes autoTables
sandynz opened a new pull request #13371:
URL: https://github.com/apache/shardingsphere/pull/13371
Fixes #13364.
Changes proposed in this pull request:
- Support create scaling job from sharding rule that includes autoTables
- Make Hikari compatible with DistSQL add resource generated dataSources
- Throw exception if job config is invalid
- Cleanup MySQL SSL warning log
- Add log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #13371: Support create scaling job from sharding rule that includes autoTables
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #13371:
URL: https://github.com/apache/shardingsphere/pull/13371#issuecomment-955670858
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13371?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#13371](https://codecov.io/gh/apache/shardingsphere/pull/13371?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b31e8db) into [master](https://codecov.io/gh/apache/shardingsphere/commit/fdbf6d26b16c53933571c4989877f925bfc1481d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (fdbf6d2) will **increase** coverage by `1.80%`.
> The diff coverage is `50.57%`.
[](https://codecov.io/gh/apache/shardingsphere/pull/13371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #13371 +/- ##
============================================
+ Coverage 61.55% 63.36% +1.80%
+ Complexity 1449 1429 -20
============================================
Files 2649 2665 +16
Lines 39579 39738 +159
Branches 6829 6832 +3
============================================
+ Hits 24364 25179 +815
+ Misses 13321 12625 -696
- Partials 1894 1934 +40
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13371?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...shardingsphere/scaling/core/api/ScalingWorker.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9hcGkvU2NhbGluZ1dvcmtlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [.../common/exception/ScalingJobCreationException.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb21tb24vZXhjZXB0aW9uL1NjYWxpbmdKb2JDcmVhdGlvbkV4Y2VwdGlvbi5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...phere/scaling/core/config/DumperConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvRHVtcGVyQ29uZmlndXJhdGlvbi5qYXZh) | `100.00% <ø> (ø)` | |
| [...phere/scaling/core/config/HandleConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvSGFuZGxlQ29uZmlndXJhdGlvbi5qYXZh) | `0.00% <ø> (ø)` | |
| [...ere/scaling/core/config/ImporterConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvSW1wb3J0ZXJDb25maWd1cmF0aW9uLmphdmE=) | `100.00% <ø> (ø)` | |
| [...ere/scaling/core/config/WorkflowConfiguration.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9jb25maWcvV29ya2Zsb3dDb25maWd1cmF0aW9uLmphdmE=) | `0.00% <ø> (ø)` | |
| [.../scaling/core/executor/job/ScalingJobExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRvci9qb2IvU2NhbGluZ0pvYkV4ZWN1dG9yLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...he/shardingsphere/scaling/core/job/ScalingJob.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvU2NhbGluZ0pvYi5qYXZh) | `75.00% <0.00%> (-3.95%)` | :arrow_down: |
| [.../scaling/core/job/preparer/ScalingJobPreparer.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcHJlcGFyZXIvU2NhbGluZ0pvYlByZXBhcmVyLmphdmE=) | `64.91% <0.00%> (-1.16%)` | :arrow_down: |
| [...sphere/scaling/core/job/schedule/JobScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2Ivc2NoZWR1bGUvSm9iU2NoZWR1bGVyLmphdmE=) | `46.55% <0.00%> (-0.82%)` | :arrow_down: |
| ... and [73 more](https://codecov.io/gh/apache/shardingsphere/pull/13371/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13371?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13371?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [fdbf6d2...b31e8db](https://codecov.io/gh/apache/shardingsphere/pull/13371?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] terrymanu merged pull request #13371: Support create scaling job from sharding rule that includes autoTables
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #13371:
URL: https://github.com/apache/shardingsphere/pull/13371
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org