You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "eladkal (via GitHub)" <gi...@apache.org> on 2024/12/02 07:43:53 UTC
[I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
eladkal opened a new issue, #44559:
URL: https://github.com/apache/airflow/issues/44559
### Body
Following [[LAZY CONSENSUS] Remove deprecations from providers prior to Airflow 2.11 release](https://lists.apache.org/thread/lhy7zhz8yxo3jjpln0ds8ogszgb9b469) this issue will track the progress of the removal status.
**How to remove?**
1. Each PR should be per provider (to make review easier). Exception to that if removing code affect also depended provider
2. Find all deprecated code in a provider and accommodate for the needed change (normally the code has deprecation warning that indicates what needs to be removed). Make sure you are not removing code that was just deprecated in recent PR and was never released in stable version. Do not bulk remove!
3. Add entry to CHANGELOG.rst with information about what was removed and how to mitigate (normally it's copy/paste with minor adjustments to the deprecation warning). Use the following block:
```
main
.....
.. warning::
All deprecated classes, parameters and features have been removed from the {provider_name} provider package.
The following breaking changes were introduced:
* what was removed and how to mitigate
```
4. If provider was already handled and introduce new deprecation do not remove again (at least not for now).
List of providers:
- [ ] airbyte
- [ ] alibaba
- [x] amazon https://github.com/apache/airflow/pull/42450
- [ ] apache.beam
- [ ] apache.cassandra
- [ ] apache.drill
- [ ] apache.druid
- [ ] apache.flink
- [ ] apache.hdfs
- [ ] apache.hive
- [ ] apache.iceberg
- [ ] apache.impala
- [ ] apache.kafka
- [ ] apache.kylin
- [ ] apache.livy
- [ ] apache.pig
- [ ] apache.pinot
- [ ] apache.spark
- [ ] apprise
- [ ] arangodb
- [ ] asana
- [ ] atlassian.jira
- [ ] celery
- [ ] cloudant
- [x] cncf.kubernetes https://github.com/apache/airflow/pulls/romsharon98
- [ ] cohere
- [ ] common.compat
- [ ] common.io
- [ ] common.sql
- [ ] databricks
- [ ] datadog
- [ ] dbt
- [ ] dingding
- [ ] discord
- [ ] docker
- [ ] edge
- [ ] elasticsearch
- [ ] exasol
- [x] fab https://github.com/apache/airflow/pull/44198
- [ ] facebook
- [ ] ftp
- [ ] github
- [ ] google
- [ ] grpc
- [ ] hashicorp
- [ ] http
- [ ] imap
- [ ] influxdb
- [ ] jdbc
- [ ] jenkins
- [ ] microsoft.azure
- [ ] microsoft.mssql
- [ ] microsoft.psrp
- [ ] microsoft.winrm
- [ ] mongo
- [ ] mysql
- [ ] neo4j
- [ ] odbc
- [ ] openai
- [ ] openfaas
- [ ] openlineage
- [ ] opensearch
- [ ] opsgenie
- [ ] oracle
- [ ] pagerduty
- [ ] papermill
- [ ] pgvector
- [ ] pinecone
- [ ] postgres
- [ ] presto
- [ ] qdrant
- [ ] redis
- [ ] salesforce
- [ ] samba
- [ ] segment
- [ ] sendgrid
- [ ] sftp
- [ ] singularity
- [ ] slack
- [ ] smtp
- [ ] snowflake
- [ ] sqlite
- [ ] ssh
- [ ] standard
- [ ] tableau
- [ ] telegram
- [ ] teradata
- [ ] trino
- [ ] vertica
- [ ] weaviate
- [ ] yandex
- [ ] ydb
- [x] zendesk No action needed
**Maintainers please update the list with the relevant PRs/status**
### Committer
- [X] I acknowledge that I am a maintainer/committer of the Apache Airflow project.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2525200519
> Updating descriptions in Github is a pain. I did it already ~10 times and it seems if others update as well then sometimes (at least 10 times already) my changes are lost. Also notes down a few multiple times which have no deprecations. Tracking a set of PRs on a bug ticket is something Github is not made for :-(
What I did it in the past is re-generating those issues automatically from time to time ... Another thing-> I did not link/update the PRs in the list just "clicked" the checkmark - it was good enough usually.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2512265819
@eladkal Iām working on the hashicorp provider and will soon raise a PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2525201299
But maybe a good idea is to do (or find?) a small tool that should do such update via API?
say:
```
breeze check-issue #12345 --with-pr #27456
```
š±
That would make it far more usable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "kunaljubce (via GitHub)" <gi...@apache.org>.
kunaljubce commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2525204298
@potiuk @jscheffl While we're at it, below also don't have any deprecations -
* apache.pig
* apache.pinot
* apache.cassandra
With the `apache.druid` PR up, looks like we're done with the Apache series of deprecations :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "kunaljubce (via GitHub)" <gi...@apache.org>.
kunaljubce commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2512213254
@eladkal So in the context of this change, are we good to deprecate the Apache Drill provider completely - https://github.com/apache/airflow/blob/3747c91afdcd0470ca29e911c589b334b357b778/providers/src/airflow/providers/apache/drill/operators/drill.py#L33?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "kunaljubce (via GitHub)" <gi...@apache.org>.
kunaljubce commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2514539500
> @eladkal So in the context of this change, are we good to deprecate the Apache Drill provider completely?
>
> https://github.com/apache/airflow/blob/3747c91afdcd0470ca29e911c589b334b357b778/providers/src/airflow/providers/apache/drill/operators/drill.py#L33
@eladkal In case you missed this message ^^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "kunaljubce (via GitHub)" <gi...@apache.org>.
kunaljubce commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2511678268
@Prab-27 If you're talking about which branch to raise the PR on, that should be `main`. Refer to the tagged PRs for inspiration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "ajitg25 (via GitHub)" <gi...@apache.org>.
ajitg25 commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2512251827
Hello @eladkal,
I have raised a [PR](https://github.com/apache/airflow/pull/44577) to remove deprecated code from Airbyte providers.
Please have a look and let me know if anychanges are required.
Thank you for your time!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "kunaljubce (via GitHub)" <gi...@apache.org>.
kunaljubce commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2525200240
FYI - Working on Apache Drill and Apache Druid deprecations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2546321456
Created a small followup https://github.com/apache/airflow/issues/44807 to make docs better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2525200066
> Updatiing
Updating descriptions in Github is a pain. I did it already ~10 times and it seems if others update as well then sometimes (at least 10 times already) my changes are lost. Also notes down a few multiple times which have no deprecations. Tracking a set of PRs on a bug ticket is something Github is not made for :-(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2512841629
@eladkal I just checked for the noted deprecations in Celery - these are purely for executor interface, not DAG author specific - and the change was just added and require Airflow 2.10.4 as minimum. If we add a breaking change, Celery can not be upgraded for Airflow 2.10.3 and below.
Therefore I'd recommend to keep the Celery deprecations for a moment. No harm for the intend to help users to migrate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2546313975
Is it done ?????! ??? š
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2513491904
@jscheffl - How can I determine the version number like 3.8.0 in CHANGELOG.rst?
I believe the version number in CHANGELOG.rst is derived from the next versions mentioned in provider.yaml .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "kunaljubce (via GitHub)" <gi...@apache.org>.
kunaljubce commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2525198671
@eladkal @jscheffl `apache.hdfs` has no deprecations. Please update the description.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal closed issue #44559: Remove deprecated code from providers before Airflow 2.11.0 release
URL: https://github.com/apache/airflow/issues/44559
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2546314879
Shall you do the honors @eladkal and close it ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "Prab-27 (via GitHub)" <gi...@apache.org>.
Prab-27 commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2511618086
Hello @potiuk
I'm a newbie I would like to confirm whether I should use the `v2-10-test` branch for this issue since it is related to version 2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2525199624
Updatiing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2525307140
<img width="267" alt="Screenshot 2024-12-07 at 21 51 20" src="https://github.com/user-attachments/assets/3d32bfa9-51a3-4270-82bc-609b86210045">
š
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "eladkal (via GitHub)" <gi...@apache.org>.
eladkal commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2513590038
> @jscheffl - How can I determine the version number like 5.0.0 in CHANGELOG.rst?
>
> I believe the version number in CHANGELOG.rst is derived from the next versions mentioned in provider.yaml .
You don't see the instructions in step 3. You set `main` not version. The version number is chosen by release manager during release time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Remove deprecated code from providers before Airflow 2.11.0 release [airflow]
Posted by "jason810496 (via GitHub)" <gi...@apache.org>.
jason810496 commented on issue #44559:
URL: https://github.com/apache/airflow/issues/44559#issuecomment-2515989333
Working on
- elasticsearch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org