You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@spark.apache.org by li...@apache.org on 2017/10/29 00:20:39 UTC
spark git commit: [MINOR] Remove false comment from
planStreamingAggregation
Repository: spark
Updated Branches:
refs/heads/master 4c5269f1a -> e80da8129
[MINOR] Remove false comment from planStreamingAggregation
## What changes were proposed in this pull request?
AggUtils.planStreamingAggregation has some comments about DISTINCT aggregates,
while streaming aggregation does not support DISTINCT.
This seems to have been wrongly copy-pasted over.
## How was this patch tested?
Only a comment change.
Author: Juliusz Sompolski <ju...@databricks.com>
Closes #18937 from juliuszsompolski/streaming-agg-doc.
Project: http://git-wip-us.apache.org/repos/asf/spark/repo
Commit: http://git-wip-us.apache.org/repos/asf/spark/commit/e80da812
Tree: http://git-wip-us.apache.org/repos/asf/spark/tree/e80da812
Diff: http://git-wip-us.apache.org/repos/asf/spark/diff/e80da812
Branch: refs/heads/master
Commit: e80da8129a6b8ebaeac0eeac603ddc461144aec3
Parents: 4c5269f
Author: Juliusz Sompolski <ju...@databricks.com>
Authored: Sat Oct 28 17:20:35 2017 -0700
Committer: gatorsmile <ga...@gmail.com>
Committed: Sat Oct 28 17:20:35 2017 -0700
----------------------------------------------------------------------
.../scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala | 3 ---
1 file changed, 3 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/spark/blob/e80da812/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
----------------------------------------------------------------------
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
index 12f8cff..ebbdf1a 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/AggUtils.scala
@@ -263,9 +263,6 @@ object AggUtils {
val partialAggregate: SparkPlan = {
val aggregateExpressions = functionsWithoutDistinct.map(_.copy(mode = Partial))
val aggregateAttributes = aggregateExpressions.map(_.resultAttribute)
- // We will group by the original grouping expression, plus an additional expression for the
- // DISTINCT column. For example, for AVG(DISTINCT value) GROUP BY key, the grouping
- // expressions will be [key, value].
createAggregate(
groupingExpressions = groupingExpressions,
aggregateExpressions = aggregateExpressions,
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@spark.apache.org
For additional commands, e-mail: commits-help@spark.apache.org