You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@linkis.apache.org by GitBox <gi...@apache.org> on 2022/03/08 13:56:59 UTC

[GitHub] [incubator-linkis] silly-carbon opened a new pull request #1636: [Feature] Use regex to match against gateway URLs, if matched, let them pass

silly-carbon opened a new pull request #1636:
URL: https://github.com/apache/incubator-linkis/pull/1636


   This PR is based on https://github.com/apache/incubator-linkis/pull/1635
   
   If we share a dashboard of Visualis in the normal way(no login required, as defined by Visualis), anonymous users would not be able to visit this shared URL because Linkis gateway would filter this URL out, don't let it pass, and this dashboard can never be really shared this way.
   
   That's not what was intended to be.
   This BUG is fixed in this PR. With REGEX Support.
   
   With "()" and "|" you can express the "OR" relation in REGEX, for instance:
   
   (.visualis.|.dss.) will MATCH URLs containing visualis OR dss, the following URLS with be matched:
   
   1. http://linkis.org/jd/visualis/vis
   2. http://linkis.org/jd/dss/vis
   
   Other URLs will NOT be matched.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [incubator-linkis] silly-carbon commented on pull request #1636: [Feature] Use regex to match against gateway URLs, if matched, let them pass

Posted by GitBox <gi...@apache.org>.
silly-carbon commented on pull request #1636:
URL: https://github.com/apache/incubator-linkis/pull/1636#issuecomment-1061805743


   @peacewong See this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [incubator-linkis] peacewong merged pull request #1636: [Feature] Use regex to match against gateway URLs, if matched, let them pass

Posted by GitBox <gi...@apache.org>.
peacewong merged pull request #1636:
URL: https://github.com/apache/incubator-linkis/pull/1636


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org

[GitHub] [incubator-linkis] peacewong commented on pull request #1636: [Feature] Use regex to match against gateway URLs, if matched, let them pass

Posted by GitBox <gi...@apache.org>.
peacewong commented on pull request #1636:
URL: https://github.com/apache/incubator-linkis/pull/1636#issuecomment-1061807910


   > @peacewong See this.
   
   ok,Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@linkis.apache.org
For additional commands, e-mail: commits-help@linkis.apache.org