[GitHub] mistercrunch closed pull request #4469: Make access request redirect to dashboard if user already has access

[GitBox <gi...@apache.org>]

mistercrunch closed pull request #4469: Make access request redirect to dashboard if user already has access
URL: https://github.com/apache/incubator-superset/pull/4469
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/superset/views/core.py b/superset/views/core.py
index e5a6bf052f..39711e121c 100755
--- a/superset/views/core.py
+++ b/superset/views/core.py
@@ -842,6 +842,15 @@ def request_access(self):
                 .one()
             )
             datasources.add(datasource)
+
+        has_access = all(
+            (
+                datasource and self.datasource_access(datasource)
+                for datasource in datasources
+            ))
+        if has_access:
+            return redirect('/superset/dashboard/{}'.format(dashboard_id))
+
         if request.args.get('action') == 'go':
             for datasource in datasources:
                 access_request = DAR(


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services