You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "lukasz-antoniak (via GitHub)" <gi...@apache.org> on 2024/07/02 16:57:57 UTC
[PR] Fix tests failing on Jenkins [cassandra-java-driver]
lukasz-antoniak opened a new pull request, #1939:
URL: https://github.com/apache/cassandra-java-driver/pull/1939
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] Fix tests failing on Jenkins [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1939:
URL: https://github.com/apache/cassandra-java-driver/pull/1939#issuecomment-2347195152
@lukasz-antoniak can you squash this down to a single commit? I can add the "patch by" and "reference" lines once we actually get this thing into the repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix tests failing on Jenkins [cassandra-java-driver]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on PR #1939:
URL: https://github.com/apache/cassandra-java-driver/pull/1939#issuecomment-2348065106
Squashed and added reference lines.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix tests failing on Jenkins [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on PR #1939:
URL: https://github.com/apache/cassandra-java-driver/pull/1939#issuecomment-2347189947
Yup, this looks right to me. Nice work @lukasz-antoniak!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix tests failing on Jenkins [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce merged PR #1939:
URL: https://github.com/apache/cassandra-java-driver/pull/1939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org
Re: [PR] Fix tests failing on Jenkins [cassandra-java-driver]
Posted by "absurdfarce (via GitHub)" <gi...@apache.org>.
absurdfarce commented on code in PR #1939:
URL: https://github.com/apache/cassandra-java-driver/pull/1939#discussion_r1662902550
##########
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteIT.java:
##########
@@ -56,8 +56,8 @@
// Do not run LWT tests in parallel because they may interfere. Tests operate on the same row.
@BackendRequirement(
type = BackendType.CASSANDRA,
- minInclusive = "3.0",
- description = ">= in WHERE clause not supported in legacy versions")
+ minInclusive = "3.4",
+ description = ">= in WHERE clause, and SASI indexes are not supported in legacy versions")
Review Comment:
I'd say make it even easier: just overload createStatements() with requiresSasiIndex as false in the default case:
```java
protected static List<String> createStatements(BaseCcmRule ccmRule) {
return createStatements(ccmRule, false);
}
```
Unless I'm missing something that means you only need to modify SelectCustomWhereClauseIT since it's the only one that actually passes in "true" for the SASI create argument.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org
Re: [PR] Fix tests failing on Jenkins [cassandra-java-driver]
Posted by "lukasz-antoniak (via GitHub)" <gi...@apache.org>.
lukasz-antoniak commented on code in PR #1939:
URL: https://github.com/apache/cassandra-java-driver/pull/1939#discussion_r1665282649
##########
integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteIT.java:
##########
@@ -56,8 +56,8 @@
// Do not run LWT tests in parallel because they may interfere. Tests operate on the same row.
@BackendRequirement(
type = BackendType.CASSANDRA,
- minInclusive = "3.0",
- description = ">= in WHERE clause not supported in legacy versions")
+ minInclusive = "3.4",
+ description = ">= in WHERE clause, and SASI indexes are not supported in legacy versions")
Review Comment:
Good for second round of review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org