You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/23 19:25:42 UTC

[GitHub] [kafka] jeqo opened a new pull request #10390: KAFKA-12536: Add Instant-based methods to ReadOnlySessionStore

jeqo opened a new pull request #10390:
URL: https://github.com/apache/kafka/pull/10390


   KIP-666 implementation.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] dotjdk commented on pull request #10390: KAFKA-12536: Add Instant-based methods to ReadOnlySessionStore

Posted by GitBox <gi...@apache.org>.
dotjdk commented on pull request #10390:
URL: https://github.com/apache/kafka/pull/10390#issuecomment-1080499059


   The parameter name changes for `fetchSession` in this commit introduces some potential confusion. Looks like a copy/paste mistake from the `findSessions` methods. `fetchSession` parameters should be called `startTime` and `endTime` as they where in previous releases.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] vvcephei merged pull request #10390: KAFKA-12536: Add Instant-based methods to ReadOnlySessionStore

Posted by GitBox <gi...@apache.org>.
vvcephei merged pull request #10390:
URL: https://github.com/apache/kafka/pull/10390


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org