[GitHub] [druid] maytasm commented on pull request #11519: Improve query error logging

[GitBox <gi...@apache.org>]

maytasm commented on pull request #11519:
URL: https://github.com/apache/druid/pull/11519#issuecomment-892473327


   @abhishekagarwal87 
   After some more thoughts, I think having this as a queryContext is a better idea. It is much easier to use as the user does not have to restart the cluster. Errors from query may come up unexpectedly (i.e. in a non-dev environment such as in production). Making this a queryContext will allow user to get more debugging information from a failing query faster and easier without having to restart the cluster. I have also follow your suggestion and rename the new queryContext to something more generic. The new context is now enableQueryDebugging, this context would not only add the Exception stracktrace but can include other current and feature functionality that would help user debug when query doesn’t work. It would include things like additional metrics and logs (not part of this PR but will create followup PRs). This one config would let us avoid add many many other configs keys by rolling up all related query debugging functionalities into one easy to remember and use queryCont
 ext. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org