[jira] [Commented] (OPENNLP-1076) SentenceSample should validate if spans are inside the text

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OPENNLP-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16022659#comment-16022659 ] 

ASF GitHub Bot commented on OPENNLP-1076:
-----------------------------------------

GitHub user kottmann opened a pull request:

    https://github.com/apache/opennlp/pull/216

    OPENNLP-1076: Add validation of spans to SentenceSample

    Thank you for contributing to Apache OpenNLP.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [ ] Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [ ] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [ ] Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kottmann/opennlp opennlp-1076

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/opennlp/pull/216.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #216
    
----
commit d378c0656ff2374a867abe0383aa841275a47d8d
Author: Jörn Kottmann <jo...@apache.org>
Date:   2017-05-24T10:10:37Z

    OPENNLP-1076: Add validation of spans to SentenceSample

----


> SentenceSample should validate if spans are inside the text
> -----------------------------------------------------------
>
>                 Key: OPENNLP-1076
>                 URL: https://issues.apache.org/jira/browse/OPENNLP-1076
>             Project: OpenNLP
>          Issue Type: Improvement
>          Components: Sentence Detector
>            Reporter: Joern Kottmann
>            Assignee: Joern Kottmann
>            Priority: Minor
>             Fix For: 1.8.1
>
>
> The SentenceSample should validate if the provided Spans to mark sentence boundaries are within bounds of the provided document text. If the spans are outside of the document text an IllegalArgumentException should be thrown to make the code fail fast. Otherwise code which processes the SentenceSamples will fail later and make it slightly harder to find the actual bug.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)