You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2023/08/28 09:08:22 UTC
[GitHub] [incubator-pekko] mdedetrich opened a new pull request, #593: Update javafmt
mdedetrich opened a new pull request, #593:
URL: https://github.com/apache/incubator-pekko/pull/593
Updates and applies javafmt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #593: Update javafmt
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #593:
URL: https://github.com/apache/incubator-pekko/pull/593#issuecomment-1695430687
I will take a try after work, wared.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #593: Update javafmt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #593:
URL: https://github.com/apache/incubator-pekko/pull/593#issuecomment-1695408090
> I tried it locally with sbt Test/compile:
>
> ```
> [info] done compiling
> [success] Total time: 591 s (09:51), completed 2023-8-28 17:48:46
> ```
If you run `validateCompile` in sbt this is where you get the problem
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #593: Update javafmt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #593:
URL: https://github.com/apache/incubator-pekko/pull/593#issuecomment-1695348797
@He-Pin There seems to be some regression in the new version of javafmt, if you look at https://github.com/apache/incubator-pekko/actions/runs/5997908862/job/16265219790?pr=593 its failing to compile some java sources
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #593: Update javafmt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #593:
URL: https://github.com/apache/incubator-pekko/pull/593#issuecomment-1695452615
https://stackoverflow.com/questions/50145575/why-does-rearranging-imports-cause-compilation-to-fail might be related, in which case we should change the formatting style or add these files into ignore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #593: Update javafmt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #593:
URL: https://github.com/apache/incubator-pekko/pull/593#issuecomment-1695441050
So I did a little digging, the core issue appear to be that the Java sources are not fed properly into the compiler i.e.
```
[error] /Users/mdedetrich/github/incubator-pekko/actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java:136:1: cannot find symbol
[error] symbol: class AbstractBehavior
[error] location: interface jdocs.org.apache.pekko.typed.AggregatorTest.IllustrateUsage
[error] AbstractBehavior
```
Now `AbstractBehavior` is defined as a Scala source in another project. Initially I thought that the problem might be with compile order so I tried to set `MultiJvm / compileOrder := CompileOrder.Mixed`/`MultiJvm / compileOrder := CompileOrder.ScalaThenJava` into MultiJvm settings but that didn't have any impact.
Now if I revert some of the changes that javafmt did on some of the source files, it does genuinely fix the issue. It appears that the import order is changing the semantics of the java source files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] He-Pin commented on pull request #593: Update javafmt
Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on PR #593:
URL: https://github.com/apache/incubator-pekko/pull/593#issuecomment-1695358732
@mdedetrich IIRC, Akka was using the newer 0.8.0 version, let me check it locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
[GitHub] [incubator-pekko] mdedetrich commented on pull request #593: Update javafmt
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on PR #593:
URL: https://github.com/apache/incubator-pekko/pull/593#issuecomment-1695419105
So I looked at diff for one of the problematic sources, i.e. `actor-typed-tests/src/test/java/jdocs/org/apache/pekko/typed/AggregatorTest.java` and all that javafmt did was re-sort the imports so I have no idea why this is failing to compile, it seems to be a multi-jvm thing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org