You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Chunwei Lei (JIRA)" <ji...@apache.org> on 2019/05/07 08:09:00 UTC

[jira] [Commented] (CALCITE-3039) In Interpreter, min() incorrectly returns maximum double value

    [ https://issues.apache.org/jira/browse/CALCITE-3039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16834475#comment-16834475 ] 

Chunwei Lei commented on CALCITE-3039:
--------------------------------------

Fixed in [da4970e647d58b2989077688d1e19747fd459d14|https://github.com/apache/calcite/commit/da4970e647d58b2989077688d1e19747fd459d14]. Thanks for the PR, [~dijkspicy].

> In Interpreter, min() incorrectly returns maximum double value
> --------------------------------------------------------------
>
>                 Key: CALCITE-3039
>                 URL: https://issues.apache.org/jira/browse/CALCITE-3039
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.17.0
>            Reporter: dijkspicy
>            Assignee: Chunwei Lei
>            Priority: Major
>              Labels: easyfix, pull-request-available
>          Time Spent: 2h 40m
>  Remaining Estimate: 0h
>
> {code:java}
> //代码占位符
> /** Implementation of {@code MIN} function to calculate the minimum of
>  * {@code float} values as a user-defined aggregate.
>  */
> public static class MinFloat extends NumericComparison<Float> {
>   public MinFloat() {
>     super(Float.MAX_VALUE, Math::min);
>   }
> }
> /** Implementation of {@code MIN} function to calculate the minimum of
>  * {@code double} and {@code real} values as a user-defined aggregate.
>  */
> public static class MinDouble extends NumericComparison<Double> {
>   public MinDouble() {
>     super(Double.MAX_VALUE, Math::max);
>   }
> }
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)