You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "dawidwys (via GitHub)" <gi...@apache.org> on 2023/10/03 14:11:23 UTC
[PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
dawidwys opened a new pull request, #23488:
URL: https://github.com/apache/flink/pull/23488
## What is the purpose of the change
The change prohibits serialising `ExecNode` with a wrong type. Previously it was possible to create a `null_null` type.
Moreover it gives a better exception when deserialising such a node.
## Brief change log
* added checks in `ExecNodeContext`
## Verifying this change
Added a test for deserialising an `ExecNode` with `null_null` type.
Added a test for serialisation in `org.apache.flink.table.planner.plan.nodes.exec.serde.ExecNodeGraphJsonSerializerTest`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / **no** / don't know)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1350384802
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -167,12 +170,19 @@ public ExecNodeContext withId(int id) {
*/
@JsonValue
public String getTypeAsString() {
+ if (name == null || version == null) {
+ throw new TableException(
+ String.format(
+ "Can not serialize ExecNode with id: %d. Missing type, this is a bug,"
+ + " please file a ticket.",
Review Comment:
The current phrasing is in line with other similar places. I would also not use a proprietary system name in the code. It's not guaranteed Apache and Flink in particular continues using JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1345519922
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -104,9 +104,16 @@ private ExecNodeContext(@Nullable Integer id, String name, Integer version) {
@JsonCreator
public ExecNodeContext(String value) {
this.id = null;
- String[] split = value.split("_");
- this.name = split[0];
- this.version = Integer.valueOf(split[1]);
+ try {
+ String[] split = value.split("_");
+ this.name = split[0];
+ this.version = Integer.valueOf(split[1]);
+ } catch (Exception e) {
+ throw new TableException(
Review Comment:
Initially I also thought of just null checking. I went for `try catch` instead of a null check, because theoretically there might be a few reasons for an exception:
1. Error while splitting.. we don't have two parts
2. Error while parsing the Integer, the second part is not a number
3. Error while parsing the Integer, the part is a null
I understand 1 & 2 are unlikely atm, but I guess we thought the same about the `null_null` situation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1350383216
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/UnsupportedNodesInPlanTest.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec;
+
+import org.apache.flink.table.api.EnvironmentSettings;
+import org.apache.flink.table.api.PlanReference;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.planner.utils.TableTestBase;
+
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests for deserialising invalid {@link org.apache.flink.table.api.CompiledPlan}. */
+public class UnsupportedNodesInPlanTest extends TableTestBase {
+
+ @Test
+ public void testInvalidType() {
+ final TableEnvironment tEnv =
+ TableEnvironment.create(EnvironmentSettings.inStreamingMode());
+ assertThatThrownBy(
+ () ->
+ tEnv.loadPlan(
+ PlanReference.fromResource(
+ "/jsonplan/testInvalidTypeJsonPlan.json")))
+ .hasRootCauseMessage(
+ "Unsupported exec node type: 'null_null'.");
Review Comment:
It is not really possible to achieve this. Please see the discussion: https://github.com/apache/flink/pull/23488#discussion_r1345505603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #23488:
URL: https://github.com/apache/flink/pull/23488#issuecomment-1745071411
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "8db7aca7cca1f6a3ac0c82e70d3de36ae7400015",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "8db7aca7cca1f6a3ac0c82e70d3de36ae7400015",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 8db7aca7cca1f6a3ac0c82e70d3de36ae7400015 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1350384802
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -167,12 +170,19 @@ public ExecNodeContext withId(int id) {
*/
@JsonValue
public String getTypeAsString() {
+ if (name == null || version == null) {
+ throw new TableException(
+ String.format(
+ "Can not serialize ExecNode with id: %d. Missing type, this is a bug,"
+ + " please file a ticket.",
Review Comment:
The current phrasing is in line with other similar places. I would also not use a proprietary system name in the code. It's not said Apache and Flink in particular continues using JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1350382539
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -105,6 +105,9 @@ private ExecNodeContext(@Nullable Integer id, String name, Integer version) {
public ExecNodeContext(String value) {
this.id = null;
String[] split = value.split("_");
+ if ("null".equals(split[0]) || "null".equals(split[1])) {
Review Comment:
Please see the discussion here: https://github.com/apache/flink/pull/23488#discussion_r1345505603
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1345505603
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -104,9 +104,16 @@ private ExecNodeContext(@Nullable Integer id, String name, Integer version) {
@JsonCreator
public ExecNodeContext(String value) {
this.id = null;
- String[] split = value.split("_");
- this.name = split[0];
- this.version = Integer.valueOf(split[1]);
+ try {
+ String[] split = value.split("_");
+ this.name = split[0];
+ this.version = Integer.valueOf(split[1]);
+ } catch (Exception e) {
+ throw new TableException(
Review Comment:
Not sure if this generic catch all is helpful. Esp instructing users to file a ticket although we already know that we serialized an invalid node. Should we explicitly check for `name == "null"` and tell users that the node is unsupported?
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -167,12 +174,19 @@ public ExecNodeContext withId(int id) {
*/
@JsonValue
public String getTypeAsString() {
+ if (name == null || version == null) {
+ throw new TableException(
+ String.format(
+ "Can not serialise ExecNode with id: %d. Missing type, this is a bug,"
Review Comment:
nit: use american english (`Can not serialize`)
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ExecNodeGraphJsonSerializerTest.java:
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.serde;
+
+import org.apache.flink.FlinkVersion;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeConfig;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeContext;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeGraph;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectWriter;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests for {@link ExecNodeGraphJsonSerializer}. */
+class ExecNodeGraphJsonSerializerTest {
+
+ @Test
+ void testSerialisingUnsupportedNode() {
Review Comment:
`testSerializing`
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/UnsupportedNodesInPlanTest.java:
##########
@@ -0,0 +1,219 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec;
+
+import org.apache.flink.table.api.EnvironmentSettings;
+import org.apache.flink.table.api.PlanReference;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.planner.utils.TableTestBase;
+
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests for deserialising invalid {@link org.apache.flink.table.api.CompiledPlan}. */
+public class UnsupportedNodesInPlanTest extends TableTestBase {
+
+ private static final String INVALID_TYPE_JSON_PLAN =
Review Comment:
nit: move this to a file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "twalthr (via GitHub)" <gi...@apache.org>.
twalthr commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1345578855
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -104,9 +104,16 @@ private ExecNodeContext(@Nullable Integer id, String name, Integer version) {
@JsonCreator
public ExecNodeContext(String value) {
this.id = null;
- String[] split = value.split("_");
- this.name = split[0];
- this.version = Integer.valueOf(split[1]);
+ try {
+ String[] split = value.split("_");
+ this.name = split[0];
+ this.version = Integer.valueOf(split[1]);
+ } catch (Exception e) {
+ throw new TableException(
Review Comment:
The null_null situation was a bug in the serialization method. During JSON deserialization so many things can go wrong if users modify the JSON plan themselves. I vote for only implement what we need for this particular use case. Also adding a comment there, why we need to to support plans older than 1.18.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #23488:
URL: https://github.com/apache/flink/pull/23488#discussion_r1347416170
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -167,12 +170,19 @@ public ExecNodeContext withId(int id) {
*/
@JsonValue
public String getTypeAsString() {
+ if (name == null || version == null) {
+ throw new TableException(
+ String.format(
+ "Can not serialize ExecNode with id: %d. Missing type, this is a bug,"
+ + " please file a ticket.",
Review Comment:
I suggest rephrasing to raising a Jira and including the url.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/serde/ExecNodeGraphJsonSerializerTest.java:
##########
@@ -0,0 +1,76 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec.serde;
+
+import org.apache.flink.FlinkVersion;
+import org.apache.flink.api.dag.Transformation;
+import org.apache.flink.configuration.Configuration;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.planner.delegation.PlannerBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeBase;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeConfig;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeContext;
+import org.apache.flink.table.planner.plan.nodes.exec.ExecNodeGraph;
+
+import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectWriter;
+
+import org.junit.jupiter.api.Test;
+
+import java.util.Collections;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests for {@link ExecNodeGraphJsonSerializer}. */
+class ExecNodeGraphJsonSerializerTest {
+
+ @Test
+ void testSerializingUnsupportedNode() {
+ final ObjectWriter objectWriter =
+ JsonSerdeUtil.createObjectWriter(JsonSerdeTestUtil.configuredSerdeContext());
+ assertThatThrownBy(
+ () ->
+ objectWriter.writeValueAsString(
+ new ExecNodeGraph(
+ FlinkVersion.v1_18,
+ Collections.singletonList(new NoAnnotationNode()))))
+ .hasMessageContaining(
+ "Can not serialize ExecNode with id: 10. Missing type, this is a bug, please file a ticket");
Review Comment:
I suggest rephrasing to raising a Jira and including the url.
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeContext.java:
##########
@@ -105,6 +105,9 @@ private ExecNodeContext(@Nullable Integer id, String name, Integer version) {
public ExecNodeContext(String value) {
this.id = null;
String[] split = value.split("_");
+ if ("null".equals(split[0]) || "null".equals(split[1])) {
Review Comment:
I am not very familiar with this code; you are saying that the value can come through as either null_xxx or yyy_null.
Is there not a way to test for these nulls prior to calling this.
Also I wonder if you should check for the failure of Integer.valueOf(split[1]); and give a nicer message in that case.
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/UnsupportedNodesInPlanTest.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.plan.nodes.exec;
+
+import org.apache.flink.table.api.EnvironmentSettings;
+import org.apache.flink.table.api.PlanReference;
+import org.apache.flink.table.api.TableEnvironment;
+import org.apache.flink.table.planner.utils.TableTestBase;
+
+import org.junit.Test;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+/** Tests for deserialising invalid {@link org.apache.flink.table.api.CompiledPlan}. */
+public class UnsupportedNodesInPlanTest extends TableTestBase {
+
+ @Test
+ public void testInvalidType() {
+ final TableEnvironment tEnv =
+ TableEnvironment.create(EnvironmentSettings.inStreamingMode());
+ assertThatThrownBy(
+ () ->
+ tEnv.loadPlan(
+ PlanReference.fromResource(
+ "/jsonplan/testInvalidTypeJsonPlan.json")))
+ .hasRootCauseMessage(
+ "Unsupported exec node type: 'null_null'.");
Review Comment:
can we test xxx_null as well, so we test the `|| "null".equals(split[1])` part of the if
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [FLINK-33179] Throw exception when serialising or deserialising ExecNode with invalid type [flink]
Posted by "dawidwys (via GitHub)" <gi...@apache.org>.
dawidwys merged PR #23488:
URL: https://github.com/apache/flink/pull/23488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org