You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by "Stefano Bagnara (JIRA)" <se...@james.apache.org> on 2008/07/19 19:05:31 UTC
[jira] Created: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Quoted-Printable encoded body no more decoded
---------------------------------------------
Key: MIME4J-59
URL: https://issues.apache.org/jira/browse/MIME4J-59
Project: Mime4j
Issue Type: Bug
Affects Versions: 0.4
Reporter: Stefano Bagnara
Fix For: 0.4
I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Niklas Therning (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615186#action_12615186 ]
Niklas Therning commented on MIME4J-59:
---------------------------------------
Or maybe it should be
int nextUnsigned = (int) next & 0xff
Anyways, I have a fix for this issue (MIME4J-59) now but it breaks some of the tests because of MIME4J-62. I think I'll check it in anyway and then I'll have a look at MIME4J-62 if it isn't too hard.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615105#action_12615105 ]
Stefano Bagnara commented on MIME4J-59:
---------------------------------------
I found what make it to change the behaviour:
if the content-type is text/plain the decoding is not done, if the content-type is application/octect-stream the decoding is done.
Do you see that, too? I'm investigating a bit more, in the mean time...
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara updated MIME4J-59:
----------------------------------
Attachment: (was: simple-7bit-body_decoded_1.txt)
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Niklas Therning
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, qp-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615176#action_12615176 ]
Stefano Bagnara commented on MIME4J-59:
---------------------------------------
I see you're working on this:
I had to change CodecUtil this way, maybe it helps you (or double check your work).
-------------
private void escape(byte next) throws IOException {
if (--nextSoftBreak <= QUOTED_PRINTABLE_OCTETS_PER_ESCAPE) {
softBreak();
}
>>> int nextUnsigned = next;
>>> if (nextUnsigned < 0) nextUnsigned += 256;
write(EQUALS);
--nextSoftBreak;
write(HEX_DIGITS[nextUnsigned >> 4]);
--nextSoftBreak;
write(HEX_DIGITS[nextUnsigned % 0x10]);
}
---------------------
But I'm not sure we should use a BinaryQuotedPrintableEncoder to make a text quoted printable.
E.g: this replace every SPACE to "=20", instead in a text translation this would be needed only if the space
is at the end of a line.
I don't know if this is an RFC requirement or if we simply can add a "Wish" JIRA issue for this.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615187#action_12615187 ]
Stefano Bagnara commented on MIME4J-59:
---------------------------------------
I opened MIME4J-63 for this. If you review it and give it a go feel free to use your more elegant solution!
Thank you!
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Oleg Kalnichevski (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615101#action_12615101 ]
Oleg Kalnichevski commented on MIME4J-59:
-----------------------------------------
By looking at simple-attachment.xml it appears obvious the content of a multipart body is expected to be left un-decoded. I think the main part and multipart bodies should be treated consistently. If you expect content to be decoded per default, I see no way around changing simple-attachment.xml (thus changing expected result of the test).
Oleg
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Oleg Kalnichevski (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615092#action_12615092 ]
Oleg Kalnichevski commented on MIME4J-59:
-----------------------------------------
Stefano,
This seems inconsistent with the expectation of the simple-attachment test case, where the base64 content does not get automatically decoded.
http://svn.apache.org/repos/asf/james/mime4j/trunk/src/test/resources/testmsgs/simple-attachment.xml
The simple-attachment test case is precisely the reason why the automatic content decoding was made optional. You can activate the content decoding by setting MimeStreamParser#setContentDecoding to true.
Am I missing something here?
Oleg
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara updated MIME4J-59:
----------------------------------
Attachment: qp-body_decoded.xml
simple-7bit-body_decoded_1.txt
qp-body.msg
Example expected message.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Niklas Therning (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615126#action_12615126 ]
Niklas Therning commented on MIME4J-59:
---------------------------------------
I have a fix for this issue which seems to work. I've modifiied TempFileTextBody to do the wrapping just like TempFileBinaryBody does. I'll commit it tomorrow.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615211#action_12615211 ]
Stefano Bagnara commented on MIME4J-59:
---------------------------------------
Great work Niklas! It works like a charm!! :-)
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Niklas Therning
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, qp-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615171#action_12615171 ]
Stefano Bagnara commented on MIME4J-59:
---------------------------------------
Thank you Niklas, this is indeed the issue.
I had a fast try with the solution you propose (add the same code we have in TempFileBinaryBody) but it results in many issues in the CodecUtil trying to create quoted printable data (array index out of bounds). One issue is that it uses bytes as if they were unsigned (they are signed in java), but I think there are more issues.
I also found issues in test code (we have a procedure to create expected files when they are not present, and they are not correctly created ATM).
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Niklas Therning (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615190#action_12615190 ]
Niklas Therning commented on MIME4J-59:
---------------------------------------
Hmmm, Stefano, I think you have attached the wrong txt file?
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Niklas Therning
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Niklas Therning (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615179#action_12615179 ]
Niklas Therning commented on MIME4J-59:
---------------------------------------
I just checked in a fix for the ArrayIndexOutOfBoundsException. With this fix you won't get the exception but theMessageWriteToTest. testBinaryAttachment* methods still fail because of the bug described in MIME4J-62.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Updated: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Stefano Bagnara updated MIME4J-59:
----------------------------------
Attachment: qp-body_decoded_1.txt
Previously attached the wrong file.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Niklas Therning
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, qp-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615103#action_12615103 ]
Stefano Bagnara commented on MIME4J-59:
---------------------------------------
Sorry Oleg, I'm not following you.
simple-attachment_decoded.xml says <binary-body name="simple-attachment_decoded_1_2.bin"/>
simple-attachment_decoded_1_2.bin contains a DECODED binary file and not the base64 version we have in simple-attachment.msg and simple-attachment.xml.
I would expect the same from the qp-body.msg test:
I would expect qp-body_decoded.xml to say <text-body name="qp-body_decoded_1.txt"/> (and this happens)
and qp-body_decoded_1.txt to be the DECODED text. Instead it is still a quoted printable text (the same happens with base64 encoding too).
Have you missed this difference or am I missing something obvious?
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Assigned: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Niklas Therning (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Therning reassigned MIME4J-59:
-------------------------------------
Assignee: Niklas Therning
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Niklas Therning
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Resolved: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Niklas Therning (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Niklas Therning resolved MIME4J-59.
-----------------------------------
Resolution: Fixed
I've added the test message and committed a fix for this issue. The fix make a couple of other tests fail. Those are related to MIME4J-62. I'll see if I can fix those tests shortly.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Assignee: Niklas Therning
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Stefano Bagnara (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615096#action_12615096 ]
Stefano Bagnara commented on MIME4J-59:
---------------------------------------
I uploaded the "decoded" expected result.
If I understand it correctly they are the expected result in their decoded form: Am I missing it?
I created this test based on old mime4j tests we had to remove for licensing issues.
I've not investigated the issue but the test you pointed (simple-attachment) is in fact decoded (look at the decoded.bin file) while this one is not decoded. Maybe the difference is being part of a multipart vs being the main part.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Niklas Therning (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615121#action_12615121 ]
Niklas Therning commented on MIME4J-59:
---------------------------------------
This bug was introduced while fixing MIME4J-37:
http://svn.apache.org/viewvc/james/mime4j/trunk/src/main/java/org/apache/james/mime4j/message/Message.java?r1=659992&r2=660013&diff_format=h
Seems like some code have changed in the Message.MessageBuilder.body(). In 0.3 we used to do the QP/Base64 wrapping based on the transfer encoding in this method but this has been removed since. Instead the TempFileBinaryBody takes the transfer encoding as a parameter and does the wrapping itself. However, the TempFileTextBody class doesn't do any wrapping. I think we need to change TempFileTextBody to take the encoding as a parameter and do the wrapping just as TempFileBinaryBody does. The Body implementations need the transfer encoding for their writeTo() methods to work properly. Right now I think the writeTo() method of TempFileTextBody is broken.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org
[jira] Commented: (MIME4J-59) Quoted-Printable encoded body no more
decoded
Posted by "Niklas Therning (JIRA)" <se...@james.apache.org>.
[ https://issues.apache.org/jira/browse/MIME4J-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12615182#action_12615182 ]
Niklas Therning commented on MIME4J-59:
---------------------------------------
I think
int nextUnsigned = next & 0xff;
should work equally well.
> Quoted-Printable encoded body no more decoded
> ---------------------------------------------
>
> Key: MIME4J-59
> URL: https://issues.apache.org/jira/browse/MIME4J-59
> Project: Mime4j
> Issue Type: Bug
> Affects Versions: 0.4
> Reporter: Stefano Bagnara
> Fix For: 0.4
>
> Attachments: qp-body.msg, qp-body_decoded.xml, simple-7bit-body_decoded_1.txt
>
>
> I'm not sure when this happened but it seems we are no more decoding quoted printable content.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org