You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/02/10 19:21:39 UTC
[GitHub] [arrow-datafusion] alamb opened a new pull request, #5244: Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237
alamb opened a new pull request, #5244:
URL: https://github.com/apache/arrow-datafusion/pull/5244
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/pull/5237
# Rationale for this change
Keep up with upstream libraries (thanks @xxchan !)
# What changes are included in this PR?
1. Update version from dependabot https://github.com/apache/arrow-datafusion/pull/5237
2. Update driver logic due to sqllogictest's API change
# Are these changes tested?
in CI
# Are there any user-facing changes?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] melgenek commented on a diff in pull request #5244: Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237
Posted by "melgenek (via GitHub)" <gi...@apache.org>.
melgenek commented on code in PR #5244:
URL: https://github.com/apache/arrow-datafusion/pull/5244#discussion_r1103165745
##########
datafusion/core/tests/sqllogictests/src/output.rs:
##########
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use sqllogictest::{DBOutput, DefaultColumnType};
+
+pub type DFColumnType = DefaultColumnType;
Review Comment:
Yes, sqllogictest was updated.
The update in this pr doesn't:
- validate types by default. By default, any types are successful as long as it can be parsed. Validation can be enabled with `runner.with_column_validator(strict_column_validator);`
- `--complete` doesn't fill in the expected types. I need to create another pr in `sqllogictest-rs`.
Anyway, I was going to work on https://github.com/apache/arrow-datafusion/issues/4499 this weekend. If you give me a couple of days, I'll create a pr with type validation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5244: Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5244:
URL: https://github.com/apache/arrow-datafusion/pull/5244#issuecomment-1426708996
Benchmark runs are scheduled for baseline = eda875bfb579cc75698c96e4207d7813cf1a8a37 and contender = 8bc035befcfca3af20c71766e95299f87de0a599. 8bc035befcfca3af20c71766e95299f87de0a599 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d17ceba197f045d1a519cef568146ba8...dfc3f2615d544ec0a11af3b8c352768c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/734dabf857cf4dff9569aaedb3f3996d...82258ea854b74ec19fe4a4abcd2d13ca/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/c5ff888683514b90a01a788853bc0f72...ff612c21ebac4f48842642266be96d86/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/268577ddb25847469bd5c7c4690a85fd...7fa551ca95074beaadbb6578b0633295/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5244: Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5244:
URL: https://github.com/apache/arrow-datafusion/pull/5244
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5244: Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5244:
URL: https://github.com/apache/arrow-datafusion/pull/5244#discussion_r1103148402
##########
datafusion/core/tests/sqllogictests/src/output.rs:
##########
@@ -0,0 +1,26 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+use sqllogictest::{DBOutput, DefaultColumnType};
+
+pub type DFColumnType = DefaultColumnType;
Review Comment:
DBOutput is now generic to support a custom column type description.
cc @melgenek as I think you were discussing this on a previous PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #5244: Update sqllogictest requirement from 0.11.1 to 0.12.0 #5237
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #5244:
URL: https://github.com/apache/arrow-datafusion/pull/5244#issuecomment-1426291957
> Anyway, I was going to work on https://github.com/apache/arrow-datafusion/issues/4499 this weekend. If you give me a couple of days, I'll create a pr with type validation.
That is great news -- thank you so much @melgenek !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org