svn commit: r1909278 - /serf/branches/1.3.x/test/test_util.c

[ko...@apache.org]

Author: kotkov
Date: Thu Apr 20 11:04:30 2023
New Revision: 1909278

URL: http://svn.apache.org/viewvc?rev=1909278&view=rev
Log:
On the '1.3.x' branch: Fix a test suite issue that is specific to this branch:
the test_https_server_proxy_setup() function wasn't checking the error status
when starting the test server.

This seems to currently be causing a segfault on the buildbot, instead of
regular test errors:
https://github.com/apache/serf/actions/runs/4745239939/jobs/8427266786

* test/test_util.c
  (test_https_server_proxy_setup): Return the error status if we fail to
   start either of the servers.

Modified:
    serf/branches/1.3.x/test/test_util.c

Modified: serf/branches/1.3.x/test/test_util.c
URL: http://svn.apache.org/viewvc/serf/branches/1.3.x/test/test_util.c?rev=1909278&r1=1909277&r2=1909278&view=diff
==============================================================================
--- serf/branches/1.3.x/test/test_util.c (original)
+++ serf/branches/1.3.x/test/test_util.c Thu Apr 20 11:04:30 2023
@@ -369,6 +369,8 @@ test_https_server_proxy_setup(test_baton
                             keyfile, certfiles, client_cn,
                             pool);
     status = start_test_server(tb->serv_ctx);
+    if (status != APR_SUCCESS)
+        return status;
 
     /* Prepare the proxy. */
     setup_test_server(&tb->proxy_ctx, tb->proxy_addr,