You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/07/15 10:51:21 UTC
[GitHub] [dubbo-go] cjphaha opened a new pull request, #1971: [WIP]: add dubbo-go cli and edit readme
cjphaha opened a new pull request, #1971:
URL: https://github.com/apache/dubbo-go/pull/1971
Move [dubbogo-cli](https://github.com/dubbogo/dubbogo-cli) to the dubbogo-cli directory and modify the readme document.
Refer https://github.com/apache/dubbo-go/issues/1799
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on a diff in pull request #1971: Ftr: add dubbo-go cli and edit readme
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #1971:
URL: https://github.com/apache/dubbo-go/pull/1971#discussion_r956689328
##########
dubbogo-cli/cmd/hessian.go:
##########
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package cmd
+
+import (
+ "runtime"
+)
+
+import (
+ "github.com/spf13/cobra"
+)
+
+import (
+ "dubbo.apache.org/dubbo-go/v3/dubbogo-cli/generator/sample"
+ "dubbo.apache.org/dubbo-go/v3/dubbogo-cli/generator/sample/hessian"
+)
+
+// hessianCmd represents the hessian-register-generator command
+var hessianCmd = &cobra.Command{
+ Use: "hessian",
+ Short: "automatic generate hessian pojo register statement",
+ Run: generateHessianRegistry,
+}
+
+func init() {
+ rootCmd.AddCommand(hessianCmd)
+ hessianCmd.Flags().StringP(hessian.CmdFlagInclude, "i", "./", "file scan directory path, default `./`")
+ hessianCmd.Flags().IntP(hessian.CmdFlagThread, "t", runtime.NumCPU()*2, "worker thread limit, default (cpu core) * 2")
+ hessianCmd.Flags().BoolP(hessian.CmdFlagOnlyError, "e", false, "only print error message, default false")
+}
+
+func generateHessianRegistry(cmd *cobra.Command, _ []string) {
+ var include string
+ var thread int
+ var onlyError bool
+ var err error
Review Comment:
放在一个 var () 代码块里面就可以了
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1971: [WIP]: add dubbo-go cli and edit readme
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on PR #1971:
URL: https://github.com/apache/dubbo-go/pull/1971#issuecomment-1200078961
pls fix the ci failure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #1971: [WIP]: add dubbo-go cli and edit readme
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on PR #1971:
URL: https://github.com/apache/dubbo-go/pull/1971#issuecomment-1186312780
pls fix the ci failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1971: [WIP]: add dubbo-go cli and edit readme
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #1971:
URL: https://github.com/apache/dubbo-go/pull/1971#issuecomment-1229183012
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1971?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1971](https://codecov.io/gh/apache/dubbo-go/pull/1971?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (df3c99f) into [3.0](https://codecov.io/gh/apache/dubbo-go/commit/9d88f3186841515d7009ce572f4bccc3e367e492?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9d88f31) will **increase** coverage by `0.14%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## 3.0 #1971 +/- ##
==========================================
+ Coverage 44.54% 44.69% +0.14%
==========================================
Files 283 283
Lines 17069 17106 +37
==========================================
+ Hits 7603 7645 +42
+ Misses 8663 8653 -10
- Partials 803 808 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1971?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `22.58% <0.00%> (ø)` | |
| [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `41.53% <0.00%> (ø)` | |
| [protocol/dubbo3/dubbo3\_protocol.go](https://codecov.io/gh/apache/dubbo-go/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8zL2R1YmJvM19wcm90b2NvbC5nbw==) | `54.54% <0.00%> (ø)` | |
| [config/graceful\_shutdown\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2dyYWNlZnVsX3NodXRkb3duX2NvbmZpZy5nbw==) | `89.83% <0.00%> (-2.90%)` | :arrow_down: |
| [config/logger\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2xvZ2dlcl9jb25maWcuZ28=) | `63.33% <0.00%> (+0.62%)` | :arrow_up: |
| [metadata/definition/definition.go](https://codecov.io/gh/apache/dubbo-go/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvZGVmaW5pdGlvbi9kZWZpbml0aW9uLmdv) | `70.66% <0.00%> (+7.87%)` | :arrow_up: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/1971/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `35.09% <0.00%> (+8.60%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #1971: Ftr: add dubbo-go cli and edit readme
Posted by GitBox <gi...@apache.org>.
AlexStocks merged PR #1971:
URL: https://github.com/apache/dubbo-go/pull/1971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] cjphaha closed pull request #1971: [WIP]: add dubbo-go cli and edit readme
Posted by GitBox <gi...@apache.org>.
cjphaha closed pull request #1971: [WIP]: add dubbo-go cli and edit readme
URL: https://github.com/apache/dubbo-go/pull/1971
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org