You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/09/09 08:11:07 UTC
[GitHub] [incubator-seatunnel] EricJoy2048 opened a new pull request, #2699: [Feature][ST-Engine] Put Job Status in IMap
EricJoy2048 opened a new pull request, #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699
fix https://github.com/apache/incubator-seatunnel/issues/2577
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r971559969
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
Review Comment:
Vaule not Tuple2
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
+ * Tuple2 key is JobMaster init timestamp and value is the jobImmutableInformation which is sent by client when submit job
+ * <p>
+ * This IMap is used to recovery runningJobInfoIMap in JobMaster when a new master node active
+ */
+ private IMap<Long, RunningJobInfo> runningJobInfoIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link JobStatus} {@link org.apache.seatunnel.engine.core.job.PipelineState}
+ * {@link org.apache.seatunnel.engine.server.execution.ExecutionState}
+ * <p>
+ * This IMap is used to recovery runningJobStateIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Object> runningJobStateIMap;
Review Comment:
It's strange jobID map PipelineState, does JobStatus can't contains PipelineState?
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
+ * Tuple2 key is JobMaster init timestamp and value is the jobImmutableInformation which is sent by client when submit job
+ * <p>
+ * This IMap is used to recovery runningJobInfoIMap in JobMaster when a new master node active
+ */
+ private IMap<Long, RunningJobInfo> runningJobInfoIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link JobStatus} {@link org.apache.seatunnel.engine.core.job.PipelineState}
+ * {@link org.apache.seatunnel.engine.server.execution.ExecutionState}
+ * <p>
+ * This IMap is used to recovery runningJobStateIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Object> runningJobStateIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link org.apache.seatunnel.engine.server.dag.physical.PhysicalPlan} stateTimestamps
+ * {@link org.apache.seatunnel.engine.server.dag.physical.SubPlan} stateTimestamps
+ * {@link org.apache.seatunnel.engine.server.dag.physical.PhysicalVertex} stateTimestamps
+ * <p>
+ * This IMap is used to recovery runningJobStateTimestampsIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Long[]> runningJobStateTimestampsIMap;
Review Comment:
I think this information just subset of RunningJobInfo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r971747235
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
+ * Tuple2 key is JobMaster init timestamp and value is the jobImmutableInformation which is sent by client when submit job
+ * <p>
+ * This IMap is used to recovery runningJobInfoIMap in JobMaster when a new master node active
+ */
+ private IMap<Long, RunningJobInfo> runningJobInfoIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link JobStatus} {@link org.apache.seatunnel.engine.core.job.PipelineState}
+ * {@link org.apache.seatunnel.engine.server.execution.ExecutionState}
+ * <p>
+ * This IMap is used to recovery runningJobStateIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Object> runningJobStateIMap;
Review Comment:
Fine, but I think this IMAP needs to be refactored in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r971650665
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
+ * Tuple2 key is JobMaster init timestamp and value is the jobImmutableInformation which is sent by client when submit job
+ * <p>
+ * This IMap is used to recovery runningJobInfoIMap in JobMaster when a new master node active
+ */
+ private IMap<Long, RunningJobInfo> runningJobInfoIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link JobStatus} {@link org.apache.seatunnel.engine.core.job.PipelineState}
+ * {@link org.apache.seatunnel.engine.server.execution.ExecutionState}
+ * <p>
+ * This IMap is used to recovery runningJobStateIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Object> runningJobStateIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link org.apache.seatunnel.engine.server.dag.physical.PhysicalPlan} stateTimestamps
+ * {@link org.apache.seatunnel.engine.server.dag.physical.SubPlan} stateTimestamps
+ * {@link org.apache.seatunnel.engine.server.dag.physical.PhysicalVertex} stateTimestamps
+ * <p>
+ * This IMap is used to recovery runningJobStateTimestampsIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Long[]> runningJobStateTimestampsIMap;
Review Comment:
> I think this information just subset of RunningJobInfo.
In my design, RunningJobInfo is will not be modified frequently. runningJobStateTimestampsIMap must modified simultaneously with Job state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
EricJoy2048 merged PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r969418434
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PipelineLocation.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.engine.server.dag.physical;
+
+import lombok.AllArgsConstructor;
+import lombok.Data;
+
+import java.io.Serializable;
+
+@AllArgsConstructor
+@Data
+public class PipelineLocation implements Serializable {
Review Comment:
There are too many things to be modified, and I don't think it's necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] Hisoka-X commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
Hisoka-X commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r971677292
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
+ * Tuple2 key is JobMaster init timestamp and value is the jobImmutableInformation which is sent by client when submit job
+ * <p>
+ * This IMap is used to recovery runningJobInfoIMap in JobMaster when a new master node active
+ */
+ private IMap<Long, RunningJobInfo> runningJobInfoIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link JobStatus} {@link org.apache.seatunnel.engine.core.job.PipelineState}
+ * {@link org.apache.seatunnel.engine.server.execution.ExecutionState}
+ * <p>
+ * This IMap is used to recovery runningJobStateIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Object> runningJobStateIMap;
Review Comment:
It's hard to read, use one map put different key value type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#issuecomment-1245401542
@hailin0 @Hisoka-X PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r971758928
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
+ * Tuple2 key is JobMaster init timestamp and value is the jobImmutableInformation which is sent by client when submit job
+ * <p>
+ * This IMap is used to recovery runningJobInfoIMap in JobMaster when a new master node active
+ */
+ private IMap<Long, RunningJobInfo> runningJobInfoIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link JobStatus} {@link org.apache.seatunnel.engine.core.job.PipelineState}
+ * {@link org.apache.seatunnel.engine.server.execution.ExecutionState}
+ * <p>
+ * This IMap is used to recovery runningJobStateIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Object> runningJobStateIMap;
Review Comment:
> Fine, but I think this IMAP needs to be refactored in the future
Ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#issuecomment-1247750470
@Hisoka-X Please review again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r971647477
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
+ * Tuple2 key is JobMaster init timestamp and value is the jobImmutableInformation which is sent by client when submit job
+ * <p>
+ * This IMap is used to recovery runningJobInfoIMap in JobMaster when a new master node active
+ */
+ private IMap<Long, RunningJobInfo> runningJobInfoIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link JobStatus} {@link org.apache.seatunnel.engine.core.job.PipelineState}
+ * {@link org.apache.seatunnel.engine.server.execution.ExecutionState}
+ * <p>
+ * This IMap is used to recovery runningJobStateIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Object> runningJobStateIMap;
Review Comment:
> It's strange jobID map PipelineState, does JobStatus can't contains PipelineState?
The key-value may be `jobId-JobStatus`, `PipelineLocaltion-PipelineState`, `TaskGroupLocation-ExecutionState`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
EricJoy2048 commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r971729183
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -73,12 +81,52 @@ public class SeaTunnelServer implements ManagedService, MembershipAwareService,
private final SeaTunnelConfig seaTunnelConfig;
+ /**
+ * IMap key is jobId and value is a Tuple2
+ * Tuple2 key is JobMaster init timestamp and value is the jobImmutableInformation which is sent by client when submit job
+ * <p>
+ * This IMap is used to recovery runningJobInfoIMap in JobMaster when a new master node active
+ */
+ private IMap<Long, RunningJobInfo> runningJobInfoIMap;
+
+ /**
+ * IMap key is one of jobId {@link org.apache.seatunnel.engine.server.dag.physical.PipelineLocation} and
+ * {@link org.apache.seatunnel.engine.server.execution.TaskGroupLocation}
+ * <p>
+ * The value of IMap is one of {@link JobStatus} {@link org.apache.seatunnel.engine.core.job.PipelineState}
+ * {@link org.apache.seatunnel.engine.server.execution.ExecutionState}
+ * <p>
+ * This IMap is used to recovery runningJobStateIMap in JobMaster when a new master node active
+ */
+ IMap<Object, Object> runningJobStateIMap;
Review Comment:
> It's hard to read, use one map put different key value type
Every IMap will create many storage file in hdfs, So I think we should try to reduce the number of IMap.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ic4y commented on a diff in pull request #2699: [Feature][ST-Engine] Put Job Status in IMap
Posted by GitBox <gi...@apache.org>.
ic4y commented on code in PR #2699:
URL: https://github.com/apache/incubator-seatunnel/pull/2699#discussion_r969193866
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/SeaTunnelServer.java:
##########
@@ -238,7 +340,18 @@ public JobStatus getJobStatus(long jobId) {
// TODO Get Job Status from JobHistoryStorage
return JobStatus.FINISHED;
}
- return runningJobMaster.getJobStatus();
+ // This method is called by operation and in the runningJobMaster.getJobStatus() we will get data from IMap.
+ // It will cause an error "Waiting for response on this thread is illegal". To solve it we need put
+ // runningJobMaster.getJobStatus() in another thread.
+ CompletableFuture<JobStatus> future = CompletableFuture.supplyAsync(() -> {
+ return runningJobMaster.getJobStatus();
+ }, executorService);
Review Comment:
I think the problem is mainly caused by some limitations of the caller of the getJobStatus method, so solving this problem should be solved by the caller. instead of being handled internally by the method. Because calling in a normal thread should not encounter this problem.
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/dag/physical/PipelineLocation.java:
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.engine.server.dag.physical;
+
+import lombok.AllArgsConstructor;
+import lombok.Data;
+
+import java.io.Serializable;
+
+@AllArgsConstructor
+@Data
+public class PipelineLocation implements Serializable {
Review Comment:
This class has duplicate content with TaskGroupLocation, it is recommended to modify TaskGroupLocation. Delete jobId and pipelineId in TaskGroupLocation and add PipelineLocation. and put this class together with TaskGroupLocation
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/master/JobMaster.java:
##########
@@ -168,26 +184,26 @@ public void handleCheckpointTimeout(long pipelineId) {
});
}
- public CompletableFuture<Void> reSchedulerPipeline(SubPlan subPlan) {
- return jobScheduler.reSchedulerPipeline(subPlan);
+ public PassiveCompletableFuture<Void> reSchedulerPipeline(SubPlan subPlan) {
+ return new PassiveCompletableFuture<>(jobScheduler.reSchedulerPipeline(subPlan));
}
- public void releasePipelineResource(int pipelineId) {
+ public void releasePipelineResource(SubPlan subPlan) {
resourceManager.releaseResources(jobImmutableInformation.getJobId(),
- Lists.newArrayList(ownedSlotProfiles.get(pipelineId).values()));
+ Lists.newArrayList(ownedSlotProfilesIMap.get(subPlan.getPipelineLocation()).values())).join();
Review Comment:
Why are released resources not removed from ownedSlotProfilesIMap?
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/TaskExecutionService.java:
##########
@@ -151,10 +151,15 @@ public synchronized PassiveCompletableFuture<TaskExecutionState> deployTask(
} else {
taskGroup = nodeEngine.getSerializationService().toObject(taskImmutableInfo.getGroup());
}
- if (executionContexts.containsKey(taskGroup.getTaskGroupLocation())) {
- throw new RuntimeException(String.format("TaskGroupLocation: %s already exists", taskGroup.getTaskGroupLocation()));
+ logger.info(String.format("deploying task %s", taskGroup.getTaskGroupLocation()));
+
+ synchronized (this) {
Review Comment:
If `synchronized` is added in this place, the `synchronized` of this method should be deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org