You are viewing a plain text version of this content. The canonical link for it is here.

Posted to users@camel.apache.org by Benjamin Graf <be...@gmx.net.INVALID> on 2024/02/13 19:03:38 UTC

Order of logName evaluation for log EIP

Hi together,

I'm struggling what would be the expected order for logName evaluation. 
The docs 
(https://camel.apache.org/components/4.0.x/eips/log-eip.html#_configuring_logging_name) 
says if not defined, it'll use the routeId set or a generated one. 
Looking into code of LogReifier 
(https://github.com/apache/camel/blob/3793981daa32567a25a2aa1628a986658f863171/core/camel-core-reifier/src/main/java/org/apache/camel/reifier/LogReifier.java#L70) 
it would use getLineNumberLoggerName() before any kind of routeId first.

What is the wanted order code or doc? Seems to be a bug, anyway :)

Regards,

Benjamin

Re: Order of logName evaluation for log EIP

Posted by Benjamin Graf <be...@gmx.net.INVALID>.

Hi Clause,

Thx for clarifying. Would this be backported to 3.22.x as well once finished?

Regards,
Benjamin 

Am 14. Februar 2024 06:54:25 MEZ schrieb Claus Ibsen <cl...@gmail.com>:
>Hi
>
>Yeah the doc is a bit outdated, and we should also only use source
>name:line if explicit enabled
>https://issues.apache.org/jira/browse/CAMEL-20418
>
>On Tue, Feb 13, 2024 at 8:03 PM Benjamin Graf <be...@gmx.net.invalid>
>wrote:
>
>> Hi together,
>>
>> I'm struggling what would be the expected order for logName evaluation.
>> The docs (
>> https://camel.apache.org/components/4.0.x/eips/log-eip.html#_configuring_logging_name)
>> says if not defined, it'll use the routeId set or a generated one. Looking
>> into code of LogReifier (
>> https://github.com/apache/camel/blob/3793981daa32567a25a2aa1628a986658f863171/core/camel-core-reifier/src/main/java/org/apache/camel/reifier/LogReifier.java#L70)
>> it would use getLineNumberLoggerName() before any kind of routeId first.
>>
>> What is the wanted order code or doc? Seems to be a bug, anyway :)
>>
>> Regards,
>>
>> Benjamin
>>
>
>

-- 
Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Re: Order of logName evaluation for log EIP

Posted by Claus Ibsen <cl...@gmail.com>.

Hi

Yeah the doc is a bit outdated, and we should also only use source
name:line if explicit enabled
https://issues.apache.org/jira/browse/CAMEL-20418

On Tue, Feb 13, 2024 at 8:03 PM Benjamin Graf <be...@gmx.net.invalid>
wrote:

> Hi together,
>
> I'm struggling what would be the expected order for logName evaluation.
> The docs (
> https://camel.apache.org/components/4.0.x/eips/log-eip.html#_configuring_logging_name)
> says if not defined, it'll use the routeId set or a generated one. Looking
> into code of LogReifier (
> https://github.com/apache/camel/blob/3793981daa32567a25a2aa1628a986658f863171/core/camel-core-reifier/src/main/java/org/apache/camel/reifier/LogReifier.java#L70)
> it would use getLineNumberLoggerName() before any kind of routeId first.
>
> What is the wanted order code or doc? Seems to be a bug, anyway :)
>
> Regards,
>
> Benjamin
>


-- 
Claus Ibsen
-----------------
@davsclaus
Camel in Action 2: https://www.manning.com/ibsen2