[GitHub] [cloudstack] shwstppr commented on a diff in pull request #7383: Add a retry mechanism for VM migration

["shwstppr (via GitHub)" <gi...@apache.org>]

shwstppr commented on code in PR #7383:
URL: https://github.com/apache/cloudstack/pull/7383#discussion_r1162669806


##########
server/src/main/java/com/cloud/vm/UserVmManagerImpl.java:
##########
@@ -641,6 +641,12 @@ public class UserVmManagerImpl extends ManagerBase implements UserVmManager, Vir
     private static final ConfigKey<Boolean> VmDestroyForcestop = new ConfigKey<Boolean>("Advanced", Boolean.class, "vm.destroy.forcestop", "false",
             "On destroy, force-stop takes this value ", true);
 
+    private static final ConfigKey<Integer> MigrateRetry = new ConfigKey<Integer>("Advanced", Integer.class, "migrate.retry", "10",

Review Comment:
   Isn't 10 retries too many?
   @benj-n do you plan to add any unit and integration tests for this?
   IMO default behaviour should be no retries and then the operator can configure as desired



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org